Summary

Always generate an AJAX_SERIAL in initialize()

Review Request #5915 — Created June 1, 2014 and discarded June 1, 2014, 3:24 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

593025c...

Reviewers

Groups

reviewboard

People

Description

Some of the unit tests end up requiring an AJAX_SERIAL, so it doesn't make
sense to conditionalize this on whether we're running a test or not. Without
this, I get several test failures.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
'reviewboard' imported but unused	reviewbot	June 1, 2014, 2:17 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/__init__.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/__init__.py
  Ignored Files:

reviewboard/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'reviewboard' imported but unused
```

I think your tree is out of date. I committed a trivial change a couple days ago that sets an AJAX_SERIAL default.

chipx86 June 1, 2014, 3:19 p.m.

(We didn't need a real value, and I didn't want to walk the tree every test that ended up calling initialize).

david June 1, 2014, 3:21 p.m.

It looks like you committed it to master but not release-2.0.x

Review Board 7.0 alpha 0 (dev)

Always generate an AJAX_SERIAL in initialize()

Information

Reviewers

Status: Discarded

reviewboard/__init__.py (Diff revision 1)