Always generate an AJAX_SERIAL in initialize()

Review Request #5915 — Created June 1, 2014 and discarded

Information

Review Board
release-2.0.x
593025c...

Reviewers

Some of the unit tests end up requiring an AJAX_SERIAL, so it doesn't make
sense to conditionalize this on whether we're running a test or not. Without
this, I get several test failures.

Ran unit tests.

Description From Last Updated

'reviewboard' imported but unused

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/__init__.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/__init__.py
      Ignored Files:
    
    
  2. reviewboard/__init__.py (Diff revision 1)
     
     
    Show all issues
     'reviewboard' imported but unused
    
  3. 
      
chipx86
  1. I think your tree is out of date. I committed a trivial change a couple days ago that sets an AJAX_SERIAL default.

    1. (We didn't need a real value, and I didn't want to walk the tree every test that ended up calling initialize).

    2. It looks like you committed it to master but not release-2.0.x

  2. 
      
david
Review request changed
Status:
Discarded