Summary

Backbone view for attachment upload

Review Request #5911 — Created June 1, 2014 and submitted Aug. 10, 2014, 10:22 p.m. — Latest diff uploaded Aug. 7, 2014, 3:50 a.m.

Information

Owner

volodymyr

Repository

Review Board

Branch

Bugs

Depends On

Blocks

5824

Reviewers

Groups

reviewboard, students

People

Description

A working version of a Backbone view for file uploads (the one that you see when you click Update -> Add File). Previously that popup is used gReviewRequest hack. Now it's a standalone view, as that view is also needed for attachment revisioning.

Side note: The only other thing that needs gReviewRequest hack is "Update Diff" popup. Once someone writes a view for that, gReviewRequest can be removed.

Testing Done

Tested:
* Uploading new attachments.
* Error when no attachment is specified.
* Multiple errors returned from server side (see screenshots).

Files