Ability to update attachments
Review Request #5824 — Created May 24, 2014 and discarded
Information | |
---|---|
volodymyr | |
Review Board | |
800 | |
|
|
6119 | |
Reviewers | |
reviewboard, students | |
This review allows users to update attachments with new version. See https://reviewboard.hackpad.com/Reviewing-attachments-tbfh4oiwTHB for description or https://www.youtube.com/watch?v=anX_rQKWSp0 for a quick demo.
Review includes: * Change to a schema to track sequences of file attachments * Modified attachment creation code to correctly assign the new parameters * Modified display logic to only show the latest element of each attachment sequence * Modified attachment review pages to include the slider
This review is aimed at project branch (see testing section for the problems description)
Performed various scenarios of adding/updating/reviewing attachments.
Current problems: * There is no beautiful UI * We are reloading the page each time slider is changed - API should be extended to load the necessary data dynamically.
Description | From | Last Updated |
---|---|---|
As per last week's meeting, we need to stick to existing terminolgoy as best as possible, instead of inventing new … |
|
|
'Max' imported but unused |
![]() |
|
Col: 72 E502 the backslash is redundant between brackets |
![]() |
|
Col: 17 E128 continuation line under-indented for visual indent |
![]() |
|
Col: 1 E302 expected 2 blank lines, found 1 |
![]() |
|
Col: 1 E302 expected 2 blank lines, found 1 |
![]() |
|
Col: 61 E211 whitespace before '[' |
![]() |
|
list comprehension redefines 'file_attachment' from line 574 |
![]() |
|
Col: 17 E122 continuation line missing indentation or outdented |
![]() |
|
Col: 61 E211 whitespace before '[' |
![]() |
|
list comprehension redefines 'file_attachment' from line 574 |
![]() |
|
Col: 17 E122 continuation line missing indentation or outdented |
![]() |
|
Col: 61 E211 whitespace before '[' |
![]() |
|
'FileAttachmentHistory' imported but unused |
![]() |
|
list comprehension redefines 'file_attachment' from line 576 |
![]() |
|
Instead of using FileAttachment.objects.filter(attachment_history=attachment_history), you can follow the reverse field (note that this particular code needs the related_name change I … |
|
|
Why not just use the FileAttachmentHistory's id field as the display position? It's already a unique integer which is auto-incremented … |
|
|
Col: 17 E122 continuation line missing indentation or outdented |
![]() |
|
We use trailing commas for lists and dicts in python. |
|
|
Care to add related_name='file_attachments' here? |
|
|
If you set default=0, you don't have to set it when creating attachments that don't use an existing FileAttachmentHistory |
|
|
This can follow the backwards relationship too: return self.file_attachments.count() - 1 Why don't you consider the first uploaded file to … |
|
|
I think it's worth creating a method on FileAttachmentHistory to return the latest revision. |
|
|
Col: 61 E211 whitespace before '[' |
![]() |
|
Can you add a docstring? |
|
|
These can be combined and made more efficient using sorted: return sorted(self.get_latest_file_attachments(), key=get_display_position) |
|
|
'FileAttachmentHistory' imported but unused |
![]() |
|
Care to just put this in the dict definition for context_data? It's not worth defining a variable unless we use … |
|
|
list comprehension redefines 'file_attachment' from line 576 |
![]() |
|
Same here. |
|
|
This can use the backwards relationship. |
|
|
Should have a trailing comma. |
|
|
I think it might be nice to pull out the upload file view into a separate change. You already have … |
|
|
It looks like 'e' isn't used in here, which will make jshint unhappy. Can you just remove it from the … |
|
|
These can be simplified: this.$el.html('<div id="revision_selector" />'); |
|
|
Can you make this use /* */, since it's a multi-line comment? |
|
|
Alignment is funky here. |
|
|
This also needs to take into account the local site name and SITE_ROOT. |
|
|
Leftover debug output? |
|
|
If you put the review request into a variable in the containing method, you could just use it here without … |
|
|
We generally put the space at the end of the first line instead of the beginning of the second. |
|
|
This can use the reverse relation. |
|
|
Col: 56 E251 unexpected spaces around keyword / parameter equals |
![]() |
|
Col: 58 E251 unexpected spaces around keyword / parameter equals |
![]() |
|
Col: 63 E502 the backslash is redundant between brackets |
![]() |
|
Col: 13 E128 continuation line under-indented for visual indent |
![]() |
|
Col: 13 E128 continuation line under-indented for visual indent |
![]() |
|
Col: 59 E502 the backslash is redundant between brackets |
![]() |
|
Col: 13 E131 continuation line unaligned for hanging indent |
![]() |
|
Col: 60 E502 the backslash is redundant between brackets |
![]() |
|
Col: 17 E131 continuation line unaligned for hanging indent |
![]() |
|
Col: 56 E251 unexpected spaces around keyword / parameter equals |
![]() |
|
Col: 58 E251 unexpected spaces around keyword / parameter equals |
![]() |
|
Col: 63 E502 the backslash is redundant between brackets |
![]() |
|
Col: 13 E128 continuation line under-indented for visual indent |
![]() |
|
Col: 13 E128 continuation line under-indented for visual indent |
![]() |
|
Col: 18 E261 at least two spaces before inline comment |
![]() |
|
Col: 59 E502 the backslash is redundant between brackets |
![]() |
|
Col: 13 E131 continuation line unaligned for hanging indent |
![]() |
|
Col: 60 E502 the backslash is redundant between brackets |
![]() |
|
Col: 17 E131 continuation line unaligned for hanging indent |
![]() |
|
Can this fit on one line? |
PE PeterTran | |
Col: 36 E131 continuation line unaligned for hanging indent |
![]() |
|
Col: 40 E131 continuation line unaligned for hanging indent |
![]() |
|
Is this a tab instead of white space? |
PE PeterTran | |
Can this be hyphen-separated for consistency with your classes? |
PE PeterTran | |
Col: 80 E501 line too long (86 > 79 characters) |
![]() |
|
Col: 80 E501 line too long (133 > 79 characters) |
![]() |
|
Col: 13 E128 continuation line under-indented for visual indent |
![]() |
|
Col: 13 E128 continuation line under-indented for visual indent |
![]() |
|
Col: 13 E128 continuation line under-indented for visual indent |
![]() |
|
Col: 13 E128 continuation line under-indented for visual indent |
![]() |

-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/attachments/models.py reviewboard/attachments/forms.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/templates/reviews/parts/file_attachment_thumbnail.html
Change Summary:
Passing and handling of sequence data; uses the WIP version of the file upload backbone view

-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/attachments/forms.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/templates/reviews/parts/file_attachment_thumbnail.html reviewboard/templates/reviews/review_request_dlgs.html

-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/attachments/forms.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/templates/reviews/parts/file_attachment_thumbnail.html reviewboard/templates/reviews/review_request_dlgs.html
-
-
reviewboard/attachments/models.py (Diff revision 2) As per last week's meeting, we need to stick to existing terminolgoy as best as possible, instead of inventing new terminology.
I strongly believe the right model is:
- A
attachment_revision
field for the revision of the file attachment. - Some way of grouping related attachments (a SHA1 or some other unique identifier, rather than an integer, would be needed, or some other table, but a SHA1 is probably fine -- you'll need to make sure this is indexed in the
Meta
class forFileAttachment
.) - A custom "through" table for the M2M field between ReviewRequest and FileAttachment that specifies the visible position the file attachment is shown at in the list of thumbnails (since right now, it's based on timestamp or ID or something, and we don't want things to shift around).
- A
Change Summary:
Addressed feedback partially.
Diff: |
Revision 3 (+71 -9)
|
---|

-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/attachments/forms.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/templates/reviews/parts/file_attachment_thumbnail.html reviewboard/templates/reviews/review_request_dlgs.html
-
reviewboard/attachments/forms.py (Diff revision 3) Col: 72 E502 the backslash is redundant between brackets
-
reviewboard/attachments/forms.py (Diff revision 3) Col: 17 E128 continuation line under-indented for visual indent
-

-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/attachments/forms.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/templates/reviews/parts/file_attachment_thumbnail.html reviewboard/templates/reviews/review_request_dlgs.html
-
Change Summary:
Now we only display the latest versions of the file; they are ordered vy FileAttachmentHistory id. Using updated view from https://reviews.reviewboard.org/r/5911/
Diff: |
Revision 4 (+116 -16)
|
---|

-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/models/base_review_request_details.py reviewboard/attachments/models.py reviewboard/attachments/forms.py reviewboard/webapi/resources/base_file_attachment.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/templates/reviews/review_request_dlgs.html reviewboard/templates/reviews/parts/file_attachment_thumbnail.html reviewboard/static/rb/js/pages/views/reviewablePageView.js reviewboard/templates/reviews/review_request_box.html
-
-
reviewboard/reviews/models/base_review_request_details.py (Diff revision 4) Col: 61 E211 whitespace before '['

-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/models/base_review_request_details.py reviewboard/attachments/models.py reviewboard/attachments/forms.py reviewboard/webapi/resources/base_file_attachment.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/templates/reviews/review_request_dlgs.html reviewboard/templates/reviews/parts/file_attachment_thumbnail.html reviewboard/static/rb/js/pages/views/reviewablePageView.js reviewboard/templates/reviews/review_request_box.html
-
reviewboard/reviews/views.py (Diff revision 4) list comprehension redefines 'file_attachment' from line 574
Diff: |
Revision 5 (+134 -18)
|
---|

-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/attachments/forms.py reviewboard/staticbundles.py reviewboard/reviews/models/base_review_request_details.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/templates/reviews/review_request_dlgs.html reviewboard/templates/reviews/parts/file_attachment_thumbnail.html reviewboard/static/rb/js/pages/views/reviewablePageView.js reviewboard/templates/reviews/review_request_box.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/attachments/forms.py reviewboard/staticbundles.py reviewboard/reviews/models/base_review_request_details.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/templates/reviews/review_request_dlgs.html reviewboard/templates/reviews/parts/file_attachment_thumbnail.html reviewboard/static/rb/js/pages/views/reviewablePageView.js reviewboard/templates/reviews/review_request_box.html
-
reviewboard/attachments/forms.py (Diff revision 5) Col: 17 E122 continuation line missing indentation or outdented
-
reviewboard/reviews/models/base_review_request_details.py (Diff revision 5) Col: 61 E211 whitespace before '['
-
reviewboard/reviews/views.py (Diff revision 5) list comprehension redefines 'file_attachment' from line 574
Change Summary:
Now this diff includes a slider that allows you to select revision of the file attachment.
Testing Done: |
|
||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 6 (+451 -20)
|

-
Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/reviews/urls.py reviewboard/attachments/forms.py reviewboard/reviews/models/base_review_request_details.py reviewboard/reviews/ui/base.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/templates/reviews/review_request_box.html reviewboard/static/rb/js/diffviewer/views/attachmentRevisionSelectorView.js reviewboard/templates/reviews/parts/file_attachment_thumbnail.html reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js reviewboard/static/rb/js/views/imageReviewableView.js reviewboard/templates/reviews/review_request_dlgs.html reviewboard/static/rb/js/pages/views/reviewablePageView.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/reviews/urls.py reviewboard/attachments/forms.py reviewboard/reviews/models/base_review_request_details.py reviewboard/reviews/ui/base.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/templates/reviews/review_request_box.html reviewboard/static/rb/js/diffviewer/views/attachmentRevisionSelectorView.js reviewboard/templates/reviews/parts/file_attachment_thumbnail.html reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js reviewboard/static/rb/js/views/imageReviewableView.js reviewboard/templates/reviews/review_request_dlgs.html reviewboard/static/rb/js/pages/views/reviewablePageView.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js
-
reviewboard/attachments/forms.py (Diff revision 6) Col: 17 E122 continuation line missing indentation or outdented
-
reviewboard/reviews/models/base_review_request_details.py (Diff revision 6) Col: 61 E211 whitespace before '['
-
-
reviewboard/reviews/views.py (Diff revision 6) list comprehension redefines 'file_attachment' from line 576
Diff: |
Revision 7 (+511 -131)
|
---|

-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/reviews/urls.py reviewboard/attachments/forms.py reviewboard/staticbundles.py reviewboard/reviews/models/base_review_request_details.py reviewboard/reviews/ui/base.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/static/rb/js/diffviewer/views/commonRevisionSelectorView.js reviewboard/templates/reviews/review_request_box.html reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js reviewboard/templates/reviews/parts/file_attachment_thumbnail.html reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js reviewboard/static/rb/js/diffviewer/views/attachmentRevisionSelectorView.js reviewboard/static/rb/js/views/imageReviewableView.js reviewboard/templates/reviews/review_request_dlgs.html reviewboard/static/rb/js/pages/views/reviewablePageView.js Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/reviews/urls.py reviewboard/attachments/forms.py reviewboard/staticbundles.py reviewboard/reviews/models/base_review_request_details.py reviewboard/reviews/ui/base.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/static/rb/js/diffviewer/views/commonRevisionSelectorView.js reviewboard/templates/reviews/review_request_box.html reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js reviewboard/templates/reviews/parts/file_attachment_thumbnail.html reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js reviewboard/static/rb/js/diffviewer/views/attachmentRevisionSelectorView.js reviewboard/static/rb/js/views/imageReviewableView.js reviewboard/templates/reviews/review_request_dlgs.html reviewboard/static/rb/js/pages/views/reviewablePageView.js
-
reviewboard/attachments/forms.py (Diff revision 7) Col: 17 E122 continuation line missing indentation or outdented
-
reviewboard/reviews/models/base_review_request_details.py (Diff revision 7) Col: 61 E211 whitespace before '['
-
-
reviewboard/reviews/views.py (Diff revision 7) list comprehension redefines 'file_attachment' from line 576
-
-
reviewboard/attachments/forms.py (Diff revision 7) Instead of using
FileAttachment.objects.filter(attachment_history=attachment_history)
, you can follow the reverse field (note that this particular code needs therelated_name
change I asked for elsewhere):attachment_revision = ( attachment_history.file_attachments .aggregate(Max('attachment_revision')) .get('attachment_revision__max') + 1)
-
reviewboard/attachments/forms.py (Diff revision 7) Why not just use the FileAttachmentHistory's id field as the display position? It's already a unique integer which is auto-incremented any time a FileAttachmentHistory is created.
-
reviewboard/attachments/forms.py (Diff revision 7) We use trailing commas for lists and dicts in python.
-
reviewboard/attachments/models.py (Diff revision 7) Care to add
related_name='file_attachments'
here? -
reviewboard/attachments/models.py (Diff revision 7) If you set default=0, you don't have to set it when creating attachments that don't use an existing
FileAttachmentHistory
-
reviewboard/attachments/models.py (Diff revision 7) This can follow the backwards relationship too:
return self.file_attachments.count() - 1
Why don't you consider the first uploaded file to be a revision? That doesn't make sense to me. It's not like with diffs where the 'orig' version is upstream.
-
reviewboard/reviews/models/base_review_request_details.py (Diff revision 7) I think it's worth creating a method on FileAttachmentHistory to return the latest revision.
-
reviewboard/reviews/models/base_review_request_details.py (Diff revision 7) Can you add a docstring?
-
reviewboard/reviews/models/base_review_request_details.py (Diff revision 7) These can be combined and made more efficient using
sorted
:return sorted(self.get_latest_file_attachments(), key=get_display_position)
-
reviewboard/reviews/views.py (Diff revision 7) Care to just put this in the dict definition for
context_data
? It's not worth defining a variable unless we use it more than once. -
-
-
-
reviewboard/static/rb/js/pages/views/reviewablePageView.js (Diff revision 7) I think it might be nice to pull out the upload file view into a separate change. You already have the view itself in a separate review request. That way we could move over to the view and get that code pushed before all the rest of this is finished.
-
reviewboard/static/rb/js/pages/views/reviewablePageView.js (Diff revision 7) It looks like
'e'
isn't used in here, which will make jshint unhappy. Can you just remove it from the argument list? -
reviewboard/static/rb/js/views/imageReviewableView.js (Diff revision 7) These can be simplified:
this.$el.html('<div id="revision_selector" />');
-
reviewboard/static/rb/js/views/imageReviewableView.js (Diff revision 7) Can you make this use
/* */
, since it's a multi-line comment? -
-
reviewboard/static/rb/js/views/imageReviewableView.js (Diff revision 7) This also needs to take into account the local site name and SITE_ROOT.
-
-
reviewboard/static/rb/js/views/imageReviewableView.js (Diff revision 7) If you put the review request into a variable in the containing method, you could just use it here without fetching it again.
-
reviewboard/webapi/resources/base_file_attachment.py (Diff revision 7) We generally put the space at the end of the first line instead of the beginning of the second.
-
reviewboard/webapi/resources/base_file_attachment.py (Diff revision 7) This can use the reverse relation.
Diff: |
Revision 8 (+183 -6)
|
---|

-
Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/attachments/forms.py reviewboard/reviews/models/base_review_request_details.py reviewboard/reviews/ui/base.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/static/rb/js/views/fileAttachmentReviewableView.js reviewboard/templates/reviews/ui/text.html reviewboard/templates/reviews/review_request_box.html reviewboard/templates/reviews/parts/file_attachment_thumbnail.html reviewboard/static/rb/js/views/textBasedReviewableView.js reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js reviewboard/static/rb/js/views/imageReviewableView.js Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/reviews/ui/generic.py reviewboard/reviews/ui/__init__.py reviewboard/attachments/forms.py reviewboard/staticbundles.py reviewboard/reviews/models/base_review_request_details.py reviewboard/reviews/ui/base.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/static/rb/js/views/fileAttachmentReviewableView.js reviewboard/templates/reviews/ui/text.html reviewboard/static/rb/js/views/reviewRequestEditorView.js reviewboard/templates/reviews/parts/file_attachment_thumbnail.html reviewboard/static/rb/js/views/textBasedReviewableView.js reviewboard/static/rb/js/views/genericReviewableView.js reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js reviewboard/static/rb/js/views/imageReviewableView.js reviewboard/templates/reviews/review_request_box.html reviewboard/static/rb/js/pages/views/reviewablePageView.js
-
reviewboard/attachments/models.py (Diff revision 8) Col: 56 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/attachments/models.py (Diff revision 8) Col: 58 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/attachments/models.py (Diff revision 8) Col: 63 E502 the backslash is redundant between brackets
-
reviewboard/attachments/models.py (Diff revision 8) Col: 13 E128 continuation line under-indented for visual indent
-
reviewboard/reviews/models/base_review_request_details.py (Diff revision 8) Col: 13 E128 continuation line under-indented for visual indent
-
reviewboard/reviews/views.py (Diff revision 8) Col: 59 E502 the backslash is redundant between brackets
-
reviewboard/reviews/views.py (Diff revision 8) Col: 13 E131 continuation line unaligned for hanging indent
-
reviewboard/reviews/views.py (Diff revision 8) Col: 60 E502 the backslash is redundant between brackets
-
reviewboard/reviews/views.py (Diff revision 8) Col: 17 E131 continuation line unaligned for hanging indent
-
reviewboard/attachments/models.py (Diff revision 9) Col: 56 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/attachments/models.py (Diff revision 9) Col: 58 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/attachments/models.py (Diff revision 9) Col: 63 E502 the backslash is redundant between brackets
-
reviewboard/attachments/models.py (Diff revision 9) Col: 13 E128 continuation line under-indented for visual indent
-
reviewboard/reviews/models/base_review_request_details.py (Diff revision 9) Col: 13 E128 continuation line under-indented for visual indent
-
reviewboard/reviews/ui/generic.py (Diff revision 9) Col: 18 E261 at least two spaces before inline comment
-
reviewboard/reviews/views.py (Diff revision 9) Col: 59 E502 the backslash is redundant between brackets
-
reviewboard/reviews/views.py (Diff revision 9) Col: 13 E131 continuation line unaligned for hanging indent
-
reviewboard/reviews/views.py (Diff revision 9) Col: 60 E502 the backslash is redundant between brackets
-
reviewboard/reviews/views.py (Diff revision 9) Col: 17 E131 continuation line unaligned for hanging indent

-
Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/reviews/ui/generic.py reviewboard/reviews/ui/__init__.py reviewboard/attachments/forms.py reviewboard/staticbundles.py reviewboard/reviews/models/base_review_request_details.py reviewboard/reviews/ui/base.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/static/rb/js/views/fileAttachmentReviewableView.js reviewboard/templates/reviews/ui/text.html reviewboard/static/rb/js/views/reviewRequestEditorView.js reviewboard/templates/reviews/parts/file_attachment_thumbnail.html reviewboard/static/rb/js/views/textBasedReviewableView.js reviewboard/static/rb/js/views/genericReviewableView.js reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js reviewboard/static/rb/js/views/imageReviewableView.js reviewboard/templates/reviews/review_request_box.html reviewboard/static/rb/js/pages/views/reviewablePageView.js
-
reviewboard/reviews/views.py (Diff revision 10) Col: 36 E131 continuation line unaligned for hanging indent
-
reviewboard/reviews/views.py (Diff revision 10) Col: 40 E131 continuation line unaligned for hanging indent
-
-
reviewboard/reviews/models/base_review_request_details.py (Diff revision 10) Can this fit on one line?
-
reviewboard/static/rb/js/views/fileAttachmentReviewableView.js (Diff revision 10) Is this a tab instead of white space?
-
reviewboard/templates/reviews/ui/text.html (Diff revision 10) Can this be hyphen-separated for consistency with your classes?
Change Summary:
Updated description
Summary: |
|
||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||||||||||||||||||||
Testing Done: |
|
Change Summary:
Added database evolution, tested it. Pulled new code. Made sure that stuff still works.
Diff: |
Revision 12 (+268 -8)
|
---|

-
Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/reviews/ui/generic.py reviewboard/reviews/ui/__init__.py reviewboard/attachments/forms.py reviewboard/staticbundles.py reviewboard/reviews/models/base_review_request_details.py reviewboard/reviews/ui/base.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/static/rb/js/views/fileAttachmentReviewableView.js reviewboard/templates/reviews/ui/text.html reviewboard/static/rb/js/views/reviewRequestEditorView.js reviewboard/templates/reviews/parts/file_attachment_thumbnail.html reviewboard/static/rb/js/views/textBasedReviewableView.js reviewboard/static/rb/js/views/genericReviewableView.js reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js reviewboard/static/rb/js/views/imageReviewableView.js reviewboard/templates/reviews/review_request_box.html reviewboard/static/rb/js/pages/views/reviewablePageView.js Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/reviews/ui/generic.py reviewboard/attachments/evolutions/__init__.py reviewboard/reviews/ui/__init__.py reviewboard/attachments/evolutions/file_attachment_revision.py reviewboard/attachments/forms.py reviewboard/staticbundles.py reviewboard/reviews/models/base_review_request_details.py reviewboard/reviews/ui/base.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/static/rb/js/views/fileAttachmentReviewableView.js reviewboard/templates/reviews/ui/text.html reviewboard/templates/reviews/review_request_box.html reviewboard/static/rb/js/views/textBasedReviewableView.js reviewboard/static/rb/js/views/genericReviewableView.js reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js reviewboard/static/rb/js/views/imageReviewableView.js
-
reviewboard/attachments/evolutions/file_attachment_revision.py (Diff revision 12) Col: 80 E501 line too long (86 > 79 characters)
-
reviewboard/attachments/evolutions/file_attachment_revision.py (Diff revision 12) Col: 80 E501 line too long (133 > 79 characters)
Change Summary:
Fixed long lines in evolution file.
Diff: |
Revision 13 (+270 -8)
|
---|
Change Summary:
Removed incorrect comment.
Diff: |
Revision 14 (+268 -8)
|
---|

-
Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/reviews/ui/generic.py reviewboard/attachments/evolutions/__init__.py reviewboard/reviews/ui/__init__.py reviewboard/attachments/evolutions/file_attachment_revision.py reviewboard/attachments/forms.py reviewboard/staticbundles.py reviewboard/reviews/models/base_review_request_details.py reviewboard/reviews/ui/base.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/static/rb/js/views/fileAttachmentReviewableView.js reviewboard/templates/reviews/ui/text.html reviewboard/templates/reviews/review_request_box.html reviewboard/static/rb/js/views/textBasedReviewableView.js reviewboard/static/rb/js/views/genericReviewableView.js reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js reviewboard/static/rb/js/views/imageReviewableView.js
-
reviewboard/attachments/evolutions/file_attachment_revision.py (Diff revision 13) Col: 13 E128 continuation line under-indented for visual indent
-
reviewboard/attachments/evolutions/file_attachment_revision.py (Diff revision 13) Col: 13 E128 continuation line under-indented for visual indent

-
Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/reviews/ui/generic.py reviewboard/attachments/evolutions/__init__.py reviewboard/reviews/ui/__init__.py reviewboard/attachments/evolutions/file_attachment_revision.py reviewboard/attachments/forms.py reviewboard/staticbundles.py reviewboard/reviews/models/base_review_request_details.py reviewboard/reviews/ui/base.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/static/rb/js/views/fileAttachmentReviewableView.js reviewboard/templates/reviews/ui/text.html reviewboard/templates/reviews/review_request_box.html reviewboard/static/rb/js/views/textBasedReviewableView.js reviewboard/static/rb/js/views/genericReviewableView.js reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js reviewboard/static/rb/js/views/imageReviewableView.js
-
reviewboard/attachments/evolutions/file_attachment_revision.py (Diff revision 14) Col: 13 E128 continuation line under-indented for visual indent
-
reviewboard/attachments/evolutions/file_attachment_revision.py (Diff revision 14) Col: 13 E128 continuation line under-indented for visual indent