Summary

Support spying on unbound functions on classes.

Review Request #5910 — Created May 31, 2014 and submitted June 2, 2014, 1:16 a.m.

Information

Owner

chipx86

Repository

kgb

Branch

master

Bugs

Depends On

Commit

d336c8b...

Reviewers

Groups

kgb

People

Description

spy_on() can now be called on an unbound function on a class (such as

ClassName.my_function), which is useful when the calling code doesn't

have a particular instance it's working on, but needs to spy on an

instance that will be created in the future.
This works just like spying on any other function.

Testing Done

Spied on an unbounded function in a unit test, was able to override the

handler for an instance created in the future.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    kgb/spies.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    kgb/spies.py
  Ignored Files:

I think the right term would be "unbound" (since the verb you're conjugating+negating is "to bind", not "to bound")

Change Summary:

Fixed the "unbounded" in the commit description.

Summary:

-	Support spying on unbounded functions on classes.
+	Support spying on unbound functions on classes.

Description:

~		spy_on() can now be called on an unbounded function on a class (such as
	~	spy_on() can now be called on an unbound function on a class (such as
		ClassName.my_function), which is useful when the calling code doesn't
		have a particular instance it's working on, but needs to spy on an
		instance that will be created in the future.

		This works just like spying on any other function.

Commit:

-	371cd31ba2309f0bd763b6a81d6745f0f07e560e
+	d336c8bec9d816d1f1720197d31164c5d9f0e991

Diff:

Revision 2 (+7 -1)

Show changes

kgb/spies.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    kgb/spies.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    kgb/spies.py
  Ignored Files:

Ship it!

```
Ship It!
```

Review Board 7.0 alpha 0 (dev)