Add a profile field controlling whether users want to receive email.

Review Request #5907 — Created May 30, 2014 and submitted

Information

Review Board
release-2.0.x
8c83e2e...

Reviewers

Not everyone wants to get emails from Review Board. This change adds a flag to
the profile to control whether users will get anything directly addressed to
them.

This implementation was done on release-2.0.x because of the testing
infrastructure, but I also plan to backport this to release-1.7.x

  • Ran unit tests
  • Tested database evolution.
  • Tested the account settings.
Description From Last Updated

Col: 9 E129 visually indented line with same indent as next logical line

reviewbotreviewbot

'Profile' imported but unused

reviewbotreviewbot

The "send_email" terminology here and especially in the functions makes it sounds like we're actually sending e-mail when called/accessed, rather …

chipx86chipx86

Should have a trailing period.

chipx86chipx86

Col: 9 E129 visually indented line with same indent as next logical line

reviewbotreviewbot

Col: 9 E129 visually indented line with same indent as next logical line

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/notifications/tests.py
        reviewboard/accounts/evolutions/__init__.py
        reviewboard/accounts/evolutions/profile_send_email.py
        reviewboard/accounts/forms/pages.py
        reviewboard/accounts/models.py
        reviewboard/notifications/email.py
      Ignored Files:
    
    
  2. reviewboard/notifications/email.py (Diff revision 1)
     
     
    Show all issues
    Col: 9
     E129 visually indented line with same indent as next logical line
    
  3. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/notifications/tests.py
        reviewboard/accounts/evolutions/__init__.py
        reviewboard/accounts/evolutions/profile_send_email.py
        reviewboard/accounts/forms/pages.py
        reviewboard/accounts/models.py
        reviewboard/notifications/email.py
      Ignored Files:
    
    
  2. reviewboard/notifications/tests.py (Diff revision 1)
     
     
    Show all issues
     'Profile' imported but unused
    
  3. 
      
david
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/notifications/tests.py
        reviewboard/accounts/evolutions/__init__.py
        reviewboard/accounts/evolutions/profile_send_email.py
        reviewboard/accounts/forms/pages.py
        reviewboard/accounts/models.py
        reviewboard/notifications/email.py
      Ignored Files:
    
    
  2. reviewboard/notifications/email.py (Diff revision 2)
     
     
    Show all issues
    Col: 9
     E129 visually indented line with same indent as next logical line
    
  3. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/notifications/tests.py
        reviewboard/accounts/evolutions/__init__.py
        reviewboard/accounts/evolutions/profile_send_email.py
        reviewboard/accounts/forms/pages.py
        reviewboard/accounts/models.py
        reviewboard/notifications/email.py
      Ignored Files:
    
    
  2. 
      
chipx86
  1. 
      
  2. reviewboard/accounts/models.py (Diff revision 2)
     
     
    Show all issues

    The "send_email" terminology here and especially in the functions makes it sounds like we're actually sending e-mail when called/accessed, rather than determining if e-mail should be sent.

    Can we change all this to "should_send_email"?

  3. reviewboard/accounts/models.py (Diff revision 2)
     
     
    Show all issues

    Should have a trailing period.

  4. 
      
david
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/notifications/tests.py
        reviewboard/accounts/evolutions/__init__.py
        reviewboard/accounts/forms/pages.py
        reviewboard/accounts/models.py
        reviewboard/notifications/email.py
        reviewboard/accounts/evolutions/profile_should_send_email.py
      Ignored Files:
    
    
  2. reviewboard/notifications/email.py (Diff revision 3)
     
     
    Show all issues
    Col: 9
     E129 visually indented line with same indent as next logical line
    
  3. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/notifications/tests.py
        reviewboard/accounts/evolutions/__init__.py
        reviewboard/accounts/forms/pages.py
        reviewboard/accounts/models.py
        reviewboard/notifications/email.py
        reviewboard/accounts/evolutions/profile_should_send_email.py
      Ignored Files:
    
    
  2. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (6985318)