Summary

Add a profile field controlling whether users want to receive email.

Review Request #5907 — Created May 30, 2014 and submitted June 2, 2014, 12:07 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

8c83e2e...

Reviewers

Groups

reviewboard

People

Description

Not everyone wants to get emails from Review Board. This change adds a flag to
the profile to control whether users will get anything directly addressed to
them.

This implementation was done on release-2.0.x because of the testing
infrastructure, but I also plan to backport this to release-1.7.x

Testing Done


Ran unit tests
Tested database evolution.
Tested the account settings.

Issues

Description	From	Last Updated
Col: 9 E129 visually indented line with same indent as next logical line	reviewbot	May 30, 2014, 4:19 p.m.
'Profile' imported but unused	reviewbot	May 30, 2014, 4:19 p.m.
The "send_email" terminology here and especially in the functions makes it sounds like we're actually sending e-mail when called/accessed, rather …	chipx86	June 1, 2014, 3:57 p.m.
Should have a trailing period.	chipx86	June 1, 2014, 3:57 p.m.
Col: 9 E129 visually indented line with same indent as next logical line	reviewbot	May 30, 2014, 4:20 p.m.
Col: 9 E129 visually indented line with same indent as next logical line	reviewbot	June 1, 2014, 4:44 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/notifications/tests.py
    reviewboard/accounts/evolutions/__init__.py
    reviewboard/accounts/evolutions/profile_send_email.py
    reviewboard/accounts/forms/pages.py
    reviewboard/accounts/models.py
    reviewboard/notifications/email.py
  Ignored Files:

reviewboard/notifications/email.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 9
 E129 visually indented line with same indent as next logical line
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/notifications/tests.py
    reviewboard/accounts/evolutions/__init__.py
    reviewboard/accounts/evolutions/profile_send_email.py
    reviewboard/accounts/forms/pages.py
    reviewboard/accounts/models.py
    reviewboard/notifications/email.py
  Ignored Files:

reviewboard/notifications/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'Profile' imported but unused
```

Commit:

65eb84eda0e7ea50142b08b31575070241218a1e

5785bea88177fc95159809b13005307020fc6e74

Diff:

Revision 2 (+61 -8)

Show changes

	reviewboard/accounts/models.py
	reviewboard/accounts/evolutions/__init__.py
	reviewboard/accounts/evolutions/profile_send_email.py
	reviewboard/accounts/forms/pages.py
	reviewboard/notifications/email.py
	reviewboard/notifications/tests.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/notifications/tests.py
    reviewboard/accounts/evolutions/__init__.py
    reviewboard/accounts/evolutions/profile_send_email.py
    reviewboard/accounts/forms/pages.py
    reviewboard/accounts/models.py
    reviewboard/notifications/email.py
  Ignored Files:

reviewboard/notifications/email.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 9
 E129 visually indented line with same indent as next logical line
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/notifications/tests.py
    reviewboard/accounts/evolutions/__init__.py
    reviewboard/accounts/evolutions/profile_send_email.py
    reviewboard/accounts/forms/pages.py
    reviewboard/accounts/models.py
    reviewboard/notifications/email.py
  Ignored Files:

reviewboard/accounts/models.py (Diff revision 2)

The issue has been resolved. Show all issues

The "send_email" terminology here and especially in the functions makes it sounds like we're actually sending e-mail when called/accessed, rather than determining if e-mail should be sent.

Can we change all this to "should_send_email"?

reviewboard/accounts/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Should have a trailing period.
```

Commit:

5785bea88177fc95159809b13005307020fc6e74

8c83e2e07eb34fba9e267dd10e7f67e21fe602ac

Diff:

Revision 3 (+61 -8)

Show changes

	reviewboard/accounts/models.py
	reviewboard/accounts/evolutions/__init__.py
	reviewboard/accounts/evolutions/profile_should_send_email.py
	reviewboard/accounts/forms/pages.py
	reviewboard/notifications/email.py
	reviewboard/notifications/tests.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/notifications/tests.py
    reviewboard/accounts/evolutions/__init__.py
    reviewboard/accounts/forms/pages.py
    reviewboard/accounts/models.py
    reviewboard/notifications/email.py
    reviewboard/accounts/evolutions/profile_should_send_email.py
  Ignored Files:

reviewboard/notifications/email.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 9
 E129 visually indented line with same indent as next logical line
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/notifications/tests.py
    reviewboard/accounts/evolutions/__init__.py
    reviewboard/accounts/forms/pages.py
    reviewboard/accounts/models.py
    reviewboard/notifications/email.py
    reviewboard/accounts/evolutions/profile_should_send_email.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (6985318)