[WIP] Updating Checklist extension

Review Request #5904 — Created May 29, 2014 and discarded

Information

rb-extension-pack
88c7cda...

Reviewers

Changed colours and layout to fit the general style of RB.
Added an innder DIV element to give the view enough padding to let the maximize icon show.
Changed icon margin to fix issue where buttons where not virtically algined, where they should be.


 

Description From Last Updated

Modules that belong to the project should always be separated from modules outside the project by a blank line (like …

chipx86chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        checklist/checklist/extension.py
      Ignored Files:
        checklist/checklist/static/css/index.css
        checklist/checklist/static/js/views/checklistView.js
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        checklist/checklist/extension.py
      Ignored Files:
        checklist/checklist/static/css/index.css
        checklist/checklist/static/js/views/checklistView.js
    
    
  2. 
      
chipx86
  1. This comment is really about the change that was already committed. Still, this should be fixed (could be done in this change).

  2. checklist/checklist/extension.py (Diff revision 1)
     
     
     

    Modules that belong to the project should always be separated from modules outside the project by a blank line (like the one that was already here).

  3. 
      
SA
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        checklist/checklist/static/css/index.css
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
      Ignored Files:
        checklist/checklist/static/css/index.css
    
    
  2. 
      
david
  1. This is obsolete now, right? Can you discard this review request?

  2. 
      
SA
Review request changed

Status: Discarded

Loading...