Summary

[WIP] Updating Checklist extension

Review Request #5904 — Created May 29, 2014 and discarded July 17, 2014, 12:21 a.m.

Information

Owner

salam0smy

Repository

rb-extension-pack

Branch

Bugs

Depends On

Commit

88c7cda...

Reviewers

Groups

reviewboard, students

People

Description

Changed colours and layout to fit the general style of RB.

Added an innder DIV element to give the view enough padding to let the maximize icon show.

Changed icon margin to fix issue where buttons where not virtically algined, where they should be.

Testing Done

Files

Issues

Description	From	Last Updated
Modules that belong to the project should always be separated from modules outside the project by a blank line (like …	chipx86	June 1, 2014, 3:45 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    checklist/checklist/extension.py
  Ignored Files:
    checklist/checklist/static/css/index.css
    checklist/checklist/static/js/views/checklistView.js

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    checklist/checklist/extension.py
  Ignored Files:
    checklist/checklist/static/css/index.css
    checklist/checklist/static/js/views/checklistView.js

Fix it!

This comment is really about the change that was already committed. Still, this should be fixed (could be done in this change).

checklist/checklist/extension.py (Diff revision 1)

An issue was opened. Show all issues

Modules that belong to the project should always be separated from modules outside the project by a blank line (like the one that was already here).

Diff:

Revision 2 (+1 -1)

Show changes

checklist/checklist/static/css/index.css

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    checklist/checklist/static/css/index.css

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
  Ignored Files:
    checklist/checklist/static/css/index.css

This is obsolete now, right? Can you discard this review request?

Status:: Discarded