Make use of FileDiff.is_new.
Review Request #5902 — Created May 29, 2014 and submitted
We have a property that does the comparison against
PRE_CREATIONfor us, so we
might as well use it. This is just a simple cleanup.
- Ran unit tests.
- Checked diffs for new files.
| Description | From | Last Updated |
|---|---|---|
|
list comprehension redefines 'file_attachment' from line 570 |
 reviewbot
|
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/diffviewer/diffutils.py Ignored Files: reviewboard/templates/reviews/diff_comment_fragment.html -
reviewboard/reviews/views.py (Diff revision 1) list comprehension redefines 'file_attachment' from line 570
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/diffviewer/diffutils.py Ignored Files: reviewboard/templates/reviews/diff_comment_fragment.html