Summary

Make use of FileDiff.is_new.

Review Request #5902 — Created May 29, 2014 and submitted May 30, 2014, 12:16 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

6aac8a6...

Reviewers

Groups

reviewboard

People

Description

We have a property that does the comparison against PRE_CREATION for us, so we
might as well use it. This is just a simple cleanup.

Testing Done


Ran unit tests.
Checked diffs for new files.

Issues

Description	From	Last Updated
list comprehension redefines 'file_attachment' from line 570	reviewbot	May 29, 2014, 5:41 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/diffviewer/diffutils.py
  Ignored Files:
    reviewboard/templates/reviews/diff_comment_fragment.html

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/diffviewer/diffutils.py
  Ignored Files:
    reviewboard/templates/reviews/diff_comment_fragment.html

reviewboard/reviews/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 list comprehension redefines 'file_attachment' from line 570
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (a1f6348)