Changed Content-Disposition from inline to attachment for raw diff download.

Review Request #5893 — Created May 28, 2014 and submitted

Information

Review Board
master
1c74e79...

Reviewers

Fixes bug #3384.

Manual testing with Chrome Version 35.0.1916.114, the affected browser. Also tested Firefox 29.0. In Chrome, Download Diff now downloads instead of displaying in the browser window.

Added unit test.

Description From Last Updated

Col: 80 E501 line too long (86 > 79 characters)

reviewbotreviewbot

local variable 'filediff' is assigned to but never used

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

list comprehension redefines 'file_attachment' from line 571

reviewbotreviewbot

local variable 'diffset' is assigned to but never used

reviewbotreviewbot

list comprehension redefines 'file_attachment' from line 571

reviewbotreviewbot

list comprehension redefines 'file_attachment' from line 571

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/tests.py
      Ignored Files:
    
    
  2. reviewboard/reviews/tests.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (86 > 79 characters)
    
  3. reviewboard/reviews/tests.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  4. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/tests.py
      Ignored Files:
    
    
  2. reviewboard/reviews/tests.py (Diff revision 1)
     
     
    Show all issues
     local variable 'filediff' is assigned to but never used
    
  3. reviewboard/reviews/views.py (Diff revision 1)
     
     
    Show all issues
     list comprehension redefines 'file_attachment' from line 571
    
  4. 
      
JA
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/tests.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/tests.py
      Ignored Files:
    
    
  2. reviewboard/reviews/tests.py (Diff revision 2)
     
     
    Show all issues
     local variable 'diffset' is assigned to but never used
    
  3. reviewboard/reviews/views.py (Diff revision 2)
     
     
    Show all issues
     list comprehension redefines 'file_attachment' from line 571
    
  4. 
      
JA
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/tests.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/tests.py
      Ignored Files:
    
    
  2. reviewboard/reviews/views.py (Diff revision 3)
     
     
    Show all issues
     list comprehension redefines 'file_attachment' from line 571
    
  3. 
      
david
  1. Ship It!

  2. 
      
JA
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (855d395)