Changed Content-Disposition from inline to attachment for raw diff download.
Review Request #5893 — Created May 28, 2014 and submitted
| Information | |
|---|---|
| javabrett | |
| Review Board | |
| master | |
| 1c74e79... | |
| Reviewers | |
| reviewboard | |
Fixes bug #3384.
Manual testing with Chrome Version 35.0.1916.114, the affected browser. Also tested Firefox 29.0. In Chrome, Download Diff now downloads instead of displaying in the browser window.
Added unit test.
| Description | From | Last Updated |
|---|---|---|
|
Col: 80 E501 line too long (86 > 79 characters) |
 reviewbot
|
|
|
local variable 'filediff' is assigned to but never used |
reviewbot
|
|
|
Col: 80 E501 line too long (89 > 79 characters) |
reviewbot
|
|
|
list comprehension redefines 'file_attachment' from line 571 |
reviewbot
|
|
|
local variable 'diffset' is assigned to but never used |
reviewbot
|
|
|
list comprehension redefines 'file_attachment' from line 571 |
reviewbot
|
|
|
list comprehension redefines 'file_attachment' from line 571 |
reviewbot
|
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests.py Ignored Files: -
reviewboard/reviews/tests.py (Diff revision 1) local variable 'filediff' is assigned to but never used
-
reviewboard/reviews/views.py (Diff revision 1) list comprehension redefines 'file_attachment' from line 571
JA
Change Summary:
Addressed bot reviews for my changes.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+12 -1) |
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests.py Ignored Files:
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests.py Ignored Files: -
reviewboard/reviews/tests.py (Diff revision 2) local variable 'diffset' is assigned to but never used
-
reviewboard/reviews/views.py (Diff revision 2) list comprehension redefines 'file_attachment' from line 571
JA
Change Summary:
Review bot.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+11 -1) |
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests.py Ignored Files:
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests.py Ignored Files: -
reviewboard/reviews/views.py (Diff revision 3) list comprehension redefines 'file_attachment' from line 571
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests.py Ignored Files: