Summary

Changed Content-Disposition from inline to attachment for raw diff download.

Review Request #5893 — Created May 28, 2014 and submitted June 3, 2014, 12:11 a.m.

Information

Owner

javabrett

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

1c74e79...

Reviewers

Groups

reviewboard

People

Description

Fixes bug #3384.

Testing Done

Manual testing with Chrome Version 35.0.1916.114, the affected browser. Also tested Firefox 29.0. In Chrome, Download Diff now downloads instead of displaying in the browser window.

Added unit test.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (86 > 79 characters)	reviewbot	May 28, 2014, 10:30 p.m.
local variable 'filediff' is assigned to but never used	reviewbot	May 28, 2014, 10:30 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	May 28, 2014, 10:30 p.m.
list comprehension redefines 'file_attachment' from line 571	reviewbot	May 28, 2014, 10:30 p.m.
local variable 'diffset' is assigned to but never used	reviewbot	May 28, 2014, 10:35 p.m.
list comprehension redefines 'file_attachment' from line 571	reviewbot	May 28, 2014, 10:35 p.m.
list comprehension redefines 'file_attachment' from line 571	reviewbot	May 28, 2014, 10:35 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/tests.py
  Ignored Files:

reviewboard/reviews/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (86 > 79 characters)
```
reviewboard/reviews/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/tests.py
  Ignored Files:

reviewboard/reviews/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'filediff' is assigned to but never used
```
reviewboard/reviews/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 list comprehension redefines 'file_attachment' from line 571
```

Change Summary:

Addressed bot reviews for my changes.

Commit:

c32709f1d14380826a494e3862f2cfe036c63c75

8044b34c10e5e548e8760635c917b4a2f002dad0

Diff:

Revision 2 (+12 -1)

Show changes

	reviewboard/reviews/tests.py
	reviewboard/reviews/views.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/tests.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/tests.py
  Ignored Files:

reviewboard/reviews/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 local variable 'diffset' is assigned to but never used
```
reviewboard/reviews/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 list comprehension redefines 'file_attachment' from line 571
```

Change Summary:

Review bot.

Commit:

8044b34c10e5e548e8760635c917b4a2f002dad0

1c74e79cfacb982373e34161fb1c3d5753c63c5c

Diff:

Revision 3 (+11 -1)

Show changes

	reviewboard/reviews/tests.py
	reviewboard/reviews/views.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/tests.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/tests.py
  Ignored Files:

reviewboard/reviews/views.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 list comprehension redefines 'file_attachment' from line 571
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (855d395)