Add unit tests for HostingServiceAccountResource.
Review Request #5891 — Created May 28, 2014 and submitted
This resource never had any accompanying tests when it was first
written. As we made changes to the resource or any other backing
services, we had no way of verifying that the code worked through the
API. It turns out, it didn't, as POSTing ended up calling save() on the
wrong object.This introduces a basic test suite for this resource.
Unit tests passed.
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/tests/mixins.py reviewboard/webapi/tests/urls.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/test_hosting_service_account.py Ignored Files: -
reviewboard/webapi/tests/test_hosting_service_account.py (Diff revision 1) local variable 'repository' is assigned to but never used
Change Summary:
Removed some code that came along from a copy/paste.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+147 -2) |
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/tests/mixins.py reviewboard/webapi/tests/urls.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/test_hosting_service_account.py Ignored Files:
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/tests/mixins.py reviewboard/webapi/tests/urls.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/test_hosting_service_account.py Ignored Files:
-
-
reviewboard/webapi/tests/urls.py (Diff revision 2) I'd prefer to flip these and test if it's HostingServiceAccount, and then use .pk there.
It might also be useful to test for int, and if it's neither, raise a ValueError.
Change Summary:
Updated to use the new
_normalize_idfrom /r/5898/
Depends On: |
|
||||
|---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 3 (+145 -2) |
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/tests/mixins.py reviewboard/webapi/tests/urls.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/test_hosting_service_account.py Ignored Files:
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/tests/mixins.py reviewboard/webapi/tests/urls.py reviewboard/webapi/tests/mimetypes.py reviewboard/webapi/tests/test_hosting_service_account.py Ignored Files: