Summary

Add unit tests for HostingServiceAccountResource.

Review Request #5891 — Created May 28, 2014 and submitted May 29, 2014, 4:44 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

~~5898~~

Commit

4145eb9...

Reviewers

Groups

reviewboard

People

Description

This resource never had any accompanying tests when it was first
written. As we made changes to the resource or any other backing
services, we had no way of verifying that the code worked through the
API. It turns out, it didn't, as POSTing ended up calling save() on the
wrong object.

This introduces a basic test suite for this resource.

Testing Done

Unit tests passed.

Issues

Description	From	Last Updated
local variable 'repository' is assigned to but never used	reviewbot	May 28, 2014, 4:10 p.m.
I'd prefer to flip these and test if it's HostingServiceAccount, and then use .pk there. It might also be useful …	david	May 29, 2014, 3:45 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/webapi/resources/hosting_service_account.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_hosting_service_account.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/webapi/resources/hosting_service_account.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_hosting_service_account.py
  Ignored Files:

reviewboard/webapi/tests/test_hosting_service_account.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'repository' is assigned to but never used
```

Change Summary:

Removed some code that came along from a copy/paste.

Commit:

58fafae315df4c8fd6714797c5f651477d85321c

719efef1222c97804c93e0c24d8fb4fe6bf7af8b

Diff:

Revision 2 (+147 -2)

Show changes

	reviewboard/webapi/resources/hosting_service_account.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/mixins.py
	reviewboard/webapi/tests/test_hosting_service_account.py
	reviewboard/webapi/tests/urls.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/webapi/resources/hosting_service_account.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_hosting_service_account.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/webapi/resources/hosting_service_account.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_hosting_service_account.py
  Ignored Files:

reviewboard/webapi/tests/urls.py (Diff revision 2)

The issue has been resolved. Show all issues

I'd prefer to flip these and test if it's HostingServiceAccount, and then use .pk there.

It might also be useful to test for int, and if it's neither, raise a ValueError.

chipx86 May 29, 2014, 3:30 p.m.

This is what the other test URL functions are doing, so it's probably best to fix them all in one go if we really want to tighten this down.

I don't mind changing it to raise a ValueError, but if something other than an int results from this, the URL lookup will fail with the repr of the resulting value, which is helpful enough.

chipx86 May 29, 2014, 3:32 p.m.

I'll do a follow-up change to this that fixes this all up, including this statement.

Change Summary:

Updated to use the new _normalize_id from /r/5898/

Depends On:

~~5898 - Make the ID checks more restrict in the webapi test URL functions.~~

Commit:

719efef1222c97804c93e0c24d8fb4fe6bf7af8b

4145eb9822db6cb2333d5432393506d0c5aec2b0

Diff:

Revision 3 (+145 -2)

Show changes

	reviewboard/webapi/resources/hosting_service_account.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/mixins.py
	reviewboard/webapi/tests/test_hosting_service_account.py
	reviewboard/webapi/tests/urls.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/webapi/resources/hosting_service_account.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_hosting_service_account.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/webapi/resources/hosting_service_account.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_hosting_service_account.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (2d58971)