Add a link in the HostingService API to related accounts.

Review Request #5889 — Created May 28, 2014 and submitted

chipx86
Review Board
master
c02aa3f...
reviewboard

The HostingService resource now links to the HostingServiceAccounts
resource in order to easily query all accounts associated with that
service.

This required adding some filtering abilities to HostingServiceAccounts.
Callers can now filter on username or on the service ID.

Unit tests pass.

Manually verified that the filtering works and that links were pointing to
the right places.

Description From Last Updated

'local_site_reverse' imported but unused

reviewbotreviewbot

local variable 'account1' is assigned to but never used

reviewbotreviewbot

local variable 'account2' is assigned to but never used

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/webapi/resources/hosting_service_account.py
        reviewboard/webapi/tests/test_hosting_service.py
        reviewboard/webapi/resources/hosting_service.py
        reviewboard/webapi/tests/test_hosting_service_account.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/webapi/resources/hosting_service_account.py
        reviewboard/webapi/tests/test_hosting_service.py
        reviewboard/webapi/resources/hosting_service.py
        reviewboard/webapi/tests/test_hosting_service_account.py
      Ignored Files:
    
    
  2.  'local_site_reverse' imported but unused
    
  3.  local variable 'account1' is assigned to but never used
    
  4.  local variable 'account2' is assigned to but never used
    
  5. 
      
chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/webapi/resources/hosting_service_account.py
        reviewboard/webapi/tests/test_hosting_service.py
        reviewboard/webapi/resources/hosting_service.py
        reviewboard/webapi/tests/test_hosting_service_account.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/webapi/resources/hosting_service_account.py
        reviewboard/webapi/tests/test_hosting_service.py
        reviewboard/webapi/resources/hosting_service.py
        reviewboard/webapi/tests/test_hosting_service_account.py
      Ignored Files:
    
    
  2. 
      
chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/webapi/resources/hosting_service_account.py
        reviewboard/webapi/tests/test_hosting_service.py
        reviewboard/webapi/resources/hosting_service.py
        reviewboard/webapi/tests/test_hosting_service_account.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/webapi/resources/hosting_service_account.py
        reviewboard/webapi/tests/test_hosting_service.py
        reviewboard/webapi/resources/hosting_service.py
        reviewboard/webapi/tests/test_hosting_service_account.py
      Ignored Files:
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (1ede5ff)
Loading...