Add a link in the HostingService API to related accounts.
Review Request #5889 — Created May 28, 2014 and submitted
The HostingService resource now links to the HostingServiceAccounts
resource in order to easily query all accounts associated with that
service.This required adding some filtering abilities to HostingServiceAccounts.
Callers can now filter on username or on the service ID.
Unit tests pass.
Manually verified that the filtering works and that links were pointing to
the right places.
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/tests/test_hosting_service.py reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/tests/test_hosting_service_account.py Ignored Files: -
reviewboard/webapi/resources/hosting_service.py (Diff revision 1) 'local_site_reverse' imported but unused
-
reviewboard/webapi/tests/test_hosting_service_account.py (Diff revision 1) local variable 'account1' is assigned to but never used
-
reviewboard/webapi/tests/test_hosting_service_account.py (Diff revision 1) local variable 'account2' is assigned to but never used
Change Summary:
Fixed unused imports and variables.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+82 -3) |
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/tests/test_hosting_service.py reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/tests/test_hosting_service_account.py Ignored Files:
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/tests/test_hosting_service.py reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/tests/test_hosting_service_account.py Ignored Files:
Change Summary:
Added a
@webapi_request_fieldsdecorator to document the filtering query arguments.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+95 -3) |
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/tests/test_hosting_service.py reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/tests/test_hosting_service_account.py Ignored Files:
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/tests/test_hosting_service.py reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/tests/test_hosting_service_account.py Ignored Files: