Use the new hosting service paginators for get_remote_repositories.
Review Request #5886 — Created May 28, 2014 and submitted
get_remote_repositoriesis now designed to support pagination, making
use of the new paginator classes. When callingget_remote_repositories,
the caller will get back anAPIPaginatorsubclass that can be used to
paginate through all results.The function also now takes a starting page for the pagination, and a
requested number of results per page.This will make it easier to write web API that interfaces with
get_remote_repositories, allowing pagination to occur as expected by
callers.Right now, only GitHub supports this function, so it's the only one that
is affected.
Unit tests passed.
Tested this by hand in the shell. Paginated back and forth between results.
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/hostingsvcs/github.py reviewboard/hostingsvcs/tests.py reviewboard/hostingsvcs/service.py Ignored Files:
Change Summary:
- Fixed
get_remote_repositoriesto accept the pagination arguments and pass them down. - Normalized the
startvalue to use 1-based pages instead of 0-based for GitHub.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+116 -76) |
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/hostingsvcs/github.py reviewboard/hostingsvcs/tests.py reviewboard/hostingsvcs/service.py Ignored Files:
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/hostingsvcs/github.py reviewboard/hostingsvcs/tests.py reviewboard/hostingsvcs/service.py Ignored Files: