Summary

Make the security checklist consider HTTP 403 as a correct response.

Review Request #5884 — Created May 27, 2014 and submitted May 27, 2014, 1:26 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

3368

Depends On

Commit

fc6bc9b...

Reviewers

Groups

reviewboard

People

Description

Some web server configurations may return HTTP 403 when trying to access

certain filetypes. In this case, we should consider that an acceptable response

when testing whether dangerous files can be executed.

Testing Done

Jury rigged up something to throw a 403 HTTPError for a certain file extension.
Saw that before this change, I could reproduce the bug. After, it claims that
everything passes.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/admin/security_checks.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/admin/security_checks.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (c458ae9)