Summary

Don't strip leading slashes for perforce diffs.

Review Request #5879 — Created May 26, 2014 and submitted May 26, 2014, 1:41 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

9c0d1b7...

Reviewers

Groups

reviewboard

People

Description

Because perforce depot paths start with //, stripping a leading slash is a bad,
bad thing. I've moved the filename normalization into the diff parser, and
overridden it in the perforce specialization.

Testing Done

Ran unit tests.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/diffviewer/parser.py
    reviewboard/scmtools/tests.py
    reviewboard/diffviewer/managers.py
    reviewboard/scmtools/perforce.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/diffviewer/parser.py
    reviewboard/scmtools/tests.py
    reviewboard/diffviewer/managers.py
    reviewboard/scmtools/perforce.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (d736837)