Always link to the current documentation URL.
Review Request #5854 — Created May 21, 2014 and submitted
We've always had to manually update the various URLs to the user manual,
and we've never been very consistent about doing that. However, this is
pretty easy to compute, so there's not much reason for us to have to
change anything.There's now a new
get_manual_url()function that's used to populate the
URL for the web UI and for rb-site. This will use a versioned manual if
it's a released build tagged 'final', or the 'dev' manual otherwise.
Looked at the HTML source to see that the URLs were correct.
Also created a site install and saw the URL it mentioned.
I tested this with release and final set, and without.
| Description | From | Last Updated |
|---|---|---|
|
'reviewboard' imported but unused |
 reviewbot
|
|
|
local variable 'manual_ver' is assigned to but never used |
reviewbot
|
|
|
import 'choice' from line 17 shadowed by loop variable |
reviewbot
|
|
|
'reviewboard' imported but unused |
reviewbot
|
|
|
import 'choice' from line 17 shadowed by loop variable |
reviewbot
|
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/admin/context_processors.py reviewboard/cmdline/rbsite.py reviewboard/__init__.py Ignored Files: reviewboard/templates/base/headerbar.html reviewboard/templates/base.html -
-
reviewboard/admin/context_processors.py (Diff revision 1) local variable 'manual_ver' is assigned to but never used
-
reviewboard/cmdline/rbsite.py (Diff revision 1) import 'choice' from line 17 shadowed by loop variable
Change Summary:
Removed some code I accidentally left behind from the first attempt at this.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+17 -8) |
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/admin/context_processors.py reviewboard/cmdline/rbsite.py reviewboard/__init__.py Ignored Files: reviewboard/templates/base/headerbar.html reviewboard/templates/base.html
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/admin/context_processors.py reviewboard/cmdline/rbsite.py reviewboard/__init__.py Ignored Files: reviewboard/templates/base/headerbar.html reviewboard/templates/base.html -
-
reviewboard/cmdline/rbsite.py (Diff revision 2) import 'choice' from line 17 shadowed by loop variable
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/admin/context_processors.py reviewboard/cmdline/rbsite.py reviewboard/__init__.py Ignored Files: reviewboard/templates/base/headerbar.html reviewboard/templates/base.html