Summary

Always link to the current documentation URL.

Review Request #5854 — Created May 21, 2014 and submitted May 22, 2014, 1:59 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

196f6d1...

Reviewers

Groups

reviewboard

People

Description

We've always had to manually update the various URLs to the user manual,

and we've never been very consistent about doing that. However, this is

pretty easy to compute, so there's not much reason for us to have to

change anything.
There's now a new get_manual_url() function that's used to populate the

URL for the web UI and for rb-site. This will use a versioned manual if

it's a released build tagged 'final', or the 'dev' manual otherwise.

Testing Done

Looked at the HTML source to see that the URLs were correct.

Also created a site install and saw the URL it mentioned.

I tested this with release and final set, and without.

Issues

Description	From	Last Updated
'reviewboard' imported but unused	reviewbot	May 21, 2014, 2:14 p.m.
local variable 'manual_ver' is assigned to but never used	reviewbot	May 21, 2014, 2:14 p.m.
import 'choice' from line 17 shadowed by loop variable	reviewbot	May 21, 2014, 2:14 p.m.
'reviewboard' imported but unused	reviewbot	May 21, 2014, 2:15 p.m.
import 'choice' from line 17 shadowed by loop variable	reviewbot	May 21, 2014, 2:15 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/admin/context_processors.py
    reviewboard/cmdline/rbsite.py
    reviewboard/__init__.py
  Ignored Files:
    reviewboard/templates/base/headerbar.html
    reviewboard/templates/base.html

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/admin/context_processors.py
    reviewboard/cmdline/rbsite.py
    reviewboard/__init__.py
  Ignored Files:
    reviewboard/templates/base/headerbar.html
    reviewboard/templates/base.html

reviewboard/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'reviewboard' imported but unused
```
reviewboard/admin/context_processors.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'manual_ver' is assigned to but never used
```
reviewboard/cmdline/rbsite.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 import 'choice' from line 17 shadowed by loop variable
```

Change Summary:

Removed some code I accidentally left behind from the first attempt at this.

Commit:

075971ac75d71359bf64e080aa37a8a3ab1145dd

196f6d1235925a7ad23912525c473f12c8a4134e

Diff:

Revision 2 (+17 -8)

Show changes

	reviewboard/__init__.py
	reviewboard/admin/context_processors.py
	reviewboard/cmdline/rbsite.py
	reviewboard/templates/base.html
	reviewboard/templates/base/headerbar.html

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/admin/context_processors.py
    reviewboard/cmdline/rbsite.py
    reviewboard/__init__.py
  Ignored Files:
    reviewboard/templates/base/headerbar.html
    reviewboard/templates/base.html

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/admin/context_processors.py
    reviewboard/cmdline/rbsite.py
    reviewboard/__init__.py
  Ignored Files:
    reviewboard/templates/base/headerbar.html
    reviewboard/templates/base.html

reviewboard/__init__.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'reviewboard' imported but unused
```
reviewboard/cmdline/rbsite.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 import 'choice' from line 17 shadowed by loop variable
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (9ad2216)

reviewboard/__init__.py (Diff revision 1)

reviewboard/__init__.py (Diff revision 2)