Keep the file index row heights consistent after loading.

Review Request #5853 — Created May 21, 2014 and submitted

Information

Review Board
release-2.0.x
36b2665...

Reviewers

When loading the files in the diff viewer, the height of the row in the
file index would fluctuate. The loaded row information was slightly
taller than when it just showed the spinner.

This was mostly due to the margin-bottom of the chunk dots. That margin
was unnecessary, even for wrapping, and has been removed.

There were also some margins for the graph icons that weren't really
needed, and a min-height on the row that didn't affect anything. I've
removed all this and standardized heights and offsets through variables.

Tested in Chrome and Firefox.

I tested a diff with many files, some containing chunk dots, some not, to verify that
the heights were always consistent even without chunk dots.

reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/css/diffviewer.less
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/css/diffviewer.less
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (1a9fc1c)
Loading...