Bullet-proof some extension and URL uninitialization code.
Review Request #5849 — Created May 21, 2014 and submitted
We hit some nasty issues where uninitializing an extension failed hard,
preventing all future attempts at uninitializing. These had to do with
the dynamically-set/removedextension.admin_siteattribute, which was
assumed to be available ifhas_admin_sitewasTrue.We now check for the existence of
admin_siteinstead, and also catch
attempts at removing non-existing URLs inDynamicURLResolver.
Unit tests passed.
| Description | From | Last Updated |
|---|---|---|
|
This should be wrapped in try/except ValueError too. |
 david
|
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: djblets/extensions/manager.py djblets/urls/resolvers.py Ignored Files:
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: djblets/extensions/manager.py djblets/urls/resolvers.py Ignored Files:
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: djblets/extensions/manager.py djblets/urls/resolvers.py Ignored Files:
-
-
djblets/extensions/manager.py (Diff revision 1) This should be wrapped in
try/except ValueErrortoo.
Change Summary:
Added another
try/except.
Branch: |
|
||||
|---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 2 (+12 -4) |
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: djblets/extensions/manager.py djblets/urls/resolvers.py Ignored Files:
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: djblets/extensions/manager.py djblets/urls/resolvers.py Ignored Files: