Summary

Bullet-proof some extension and URL uninitialization code.

Review Request #5849 — Created May 21, 2014 and submitted May 21, 2014, 1:54 a.m.

Information

Owner

chipx86

Repository

Djblets

Branch

master

Bugs

Depends On

Commit

7b7779e...

Reviewers

Groups

djblets

People

Description

We hit some nasty issues where uninitializing an extension failed hard,
preventing all future attempts at uninitializing. These had to do with
the dynamically-set/removed extension.admin_site attribute, which was
assumed to be available if has_admin_site was True.

We now check for the existence of admin_site instead, and also catch
attempts at removing non-existing URLs in DynamicURLResolver.

Testing Done

Unit tests passed.

Issues

Description	From	Last Updated
This should be wrapped in try/except ValueError too.	david	May 21, 2014, 1:37 a.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    djblets/extensions/manager.py
    djblets/urls/resolvers.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    djblets/extensions/manager.py
    djblets/urls/resolvers.py
  Ignored Files:

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    djblets/extensions/manager.py
    djblets/urls/resolvers.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    djblets/extensions/manager.py
    djblets/urls/resolvers.py
  Ignored Files:

djblets/extensions/manager.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should be wrapped in try/except ValueError too.
```

Change Summary:

Added another try/except.

Branch:

release-0.8.x

master

Commit:

43cf6d8efee6915756895820c280cfb68fe9089a

7b7779e2a14112d5306722e3e7747d04ee8e3bbf

Diff:

Revision 2 (+12 -4)

Show changes

	djblets/extensions/manager.py
	djblets/urls/resolvers.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    djblets/extensions/manager.py
    djblets/urls/resolvers.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    djblets/extensions/manager.py
    djblets/urls/resolvers.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (891d566)