• 
      

    Fix displaying the review request draft banner after an edit.

    Review Request #5848 — Created May 21, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    58133d5...

    Reviewers

    A regression in one of the later RCs broke displaying the draft banner
    after editing an existing published review request. The placeholder
    banner in the DOM was being set prematurely as the active banner, and
    never shown.

    We now only add the banner up-front if it's visible, and we make sure to
    show it when needed.

    Tested editing a review request without a draft banner.

    Tested loading review requests with drafts, and ones that were closed
    (both discarded and submitted).

    Unit tests pass.

    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
        Ignored Files:
          reviewboard/static/rb/js/views/reviewRequestEditorView.js
      
      
    2. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
        Ignored Files:
          reviewboard/static/rb/js/views/reviewRequestEditorView.js
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (3c34b29)