Fix some URL reversing breakages on Local Sites.
Review Request #5847 — Created May 20, 2014 and submitted
When generating the download links for files in the diff viewer, we were
callingreverse()
instead oflocal_site_reverse()
. This led to a failure
when used on a LocalSite. We now use the proper function.Search results were also calling
reverse()
, instead of
local_site_reverse()
, when attempting to take the user to the All Review
Requests page.
Tested with a Local Site. No more resolve failures.
Description | From | Last Updated |
---|---|---|
list comprehension redefines 'file_attachment' from line 571 |
reviewbot |
Change Summary:
Failed to
git add
a fix for a missing paren.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+19 -12) |
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py Ignored Files:
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/reviews/views.py Ignored Files:
-
reviewboard/reviews/views.py (Diff revision 2) list comprehension redefines 'file_attachment' from line 571