Summary

Fix some URL reversing breakages on Local Sites.

Review Request #5847 — Created May 21, 2014 and submitted May 21, 2014, 8:41 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

71d291f...

Reviewers

Groups

reviewboard

People

Description

When generating the download links for files in the diff viewer, we were
calling reverse() instead of local_site_reverse(). This led to a failure
when used on a LocalSite. We now use the proper function.

Search results were also calling reverse(), instead of
local_site_reverse(), when attempting to take the user to the All Review
Requests page.

Testing Done

Tested with a Local Site. No more resolve failures.

Issues

Description	From	Last Updated
list comprehension redefines 'file_attachment' from line 571	reviewbot	May 21, 2014, 8:25 a.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
  Ignored Files:

Change Summary:

Failed to git add a fix for a missing paren.

Commit:

4426629af0c3d4aba750a2d1b110bbdae1b7f15b

71d291fdf289fb2313509c021c0a98de0ca667c7

Diff:

Revision 2 (+19 -12)

Show changes

reviewboard/reviews/views.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/reviews/views.py
  Ignored Files:

reviewboard/reviews/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 list comprehension redefines 'file_attachment' from line 571
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (10dc455)