Fix some URL reversing breakages on Local Sites.

Review Request #5847 — Created May 20, 2014 and submitted

Information

Review Board
release-2.0.x
71d291f...

Reviewers

When generating the download links for files in the diff viewer, we were
calling reverse() instead of local_site_reverse(). This led to a failure
when used on a LocalSite. We now use the proper function.

Search results were also calling reverse(), instead of
local_site_reverse(), when attempting to take the user to the All Review
Requests page.

Tested with a Local Site. No more resolve failures.

Description From Last Updated

list comprehension redefines 'file_attachment' from line 571

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/views.py
      Ignored Files:
    
    
  2. 
      
chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/views.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/reviews/views.py
      Ignored Files:
    
    
  2. reviewboard/reviews/views.py (Diff revision 2)
     
     
    Show all issues
     list comprehension redefines 'file_attachment' from line 571
    
  3. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (10dc455)