Summary

Properly decode post-commit svn diff contents to Unicode.

Review Request #5845 — Created May 20, 2014 and submitted May 21, 2014, 1:34 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

3353

Depends On

Commit

a51a670...

Reviewers

Groups

reviewboard

People

Description

SCMTool.get_change is expected to return a Commit object with a 'diff'

parameter that is a unicode object. The SVN libraries both return diffs in

string format, which need to be decoded.

Testing Done

Ran unit tests.

Expand All
Collapse All

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/scmtools/svn/subvertpy.py
    reviewboard/scmtools/svn/pysvn.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/scmtools/svn/subvertpy.py
    reviewboard/scmtools/svn/pysvn.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (4c00183)