Properly decode post-commit svn diff contents to Unicode.

Review Request #5845 — Created May 20, 2014 and submitted

Information

Review Board
release-2.0.x
a51a670...

Reviewers

SCMTool.get_change is expected to return a Commit object with a 'diff'
parameter that is a unicode object. The SVN libraries both return diffs in
string format, which need to be decoded.

Ran unit tests.

reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/scmtools/svn/subvertpy.py
        reviewboard/scmtools/svn/pysvn.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/scmtools/svn/subvertpy.py
        reviewboard/scmtools/svn/pysvn.py
      Ignored Files:
    
    
  2. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (4c00183)