Break a circular reference in diffutils.

Review Request #5839 — Created May 19, 2014 and submitted

Information

Review Board
release-2.0.x
b93f9b1...

Reviewers

diffutils imports from Profile, which eventually imports diffutils
again, through a chain of imports. Depending on what's been imported
first, things are fine, and in fact, Review Board itself has no problems
with this. However, an extension trying to import from diffutils will
end up hitting this issue.

We only had the Profile import for the purpose of the DoesNotExist
exception. Instead, we can easily replace that with the more generic
ObjectDoesNotExist, breaking this cycle.

Unit tests pass.

The code I was writing that hit this no longer had an issue importing.

reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/diffviewer/diffutils.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/diffviewer/diffutils.py
      Ignored Files:
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (483d66d)
Loading...