Summary

Fix posting submitted changelists for perforce.

Review Request #5837 — Created May 16, 2014 and submitted May 18, 2014, 11:23 p.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

3347

Depends On

Commit

ca6470b...

Reviewers

Groups

rbtools

People

Description

The code to post submitted changelists would end up posting a diff for both
the intended change and the one preceeding it. This is because we passed in
our (base, tip] revisions for 'p4 filelog', which itself behaves as [base,
tip]. To work around this, I've added code to increment the base revision
before calling filelog.

Testing Done

Ran unit tests.

Expand All
Collapse All

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbtools/clients/perforce.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    rbtools/clients/perforce.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.6.x (b64f6a4)