Decode author and commit messages coming from pysvn/subvertpy.

Review Request #5835 — Created May 16, 2014 and submitted

Information

Review Board
release-2.0.x
b0df0ca...

Reviewers

Post-commit review request creation with SVN worked fine when the commit
messages and author names were ASCII, but failed if there were unicode
characters. I've gone through the source for both libraries and verified that
this data is provided as a string, so we need to decode it to a unicode object.

Ran unit tests.

reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/scmtools/svn/subvertpy.py
        reviewboard/scmtools/svn/pysvn.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/scmtools/svn/subvertpy.py
        reviewboard/scmtools/svn/pysvn.py
      Ignored Files:
    
    
  2. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (f16266e)
Loading...