Ability to update attachments
Review Request #5824 — Created May 24, 2014 and discarded — Latest diff uploaded
This review allows users to update attachments with new version. See https://reviewboard.hackpad.com/Reviewing-attachments-tbfh4oiwTHB for description or https://www.youtube.com/watch?v=anX_rQKWSp0 for a quick demo.
Review includes: * Change to a schema to track sequences of file attachments * Modified attachment creation code to correctly assign the new parameters * Modified display logic to only show the latest element of each attachment sequence * Modified attachment review pages to include the slider
This review is aimed at project branch (see testing section for the problems description)
Performed various scenarios of adding/updating/reviewing attachments.
Current problems: * There is no beautiful UI * We are reloading the page each time slider is changed - API should be extended to load the necessary data dynamically.
Diff Revision 4
This is not the most recent revision of the diff. The latest diff is revision 14. See what's changed.
| reviewboard/attachments/forms.py |
|---|
| reviewboard/attachments/models.py |
|---|
| reviewboard/reviews/views.py |
|---|
| reviewboard/reviews/models/base_review_request_details.py |
|---|
| reviewboard/static/rb/js/pages/views/reviewablePageView.js |
|---|
| reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js |
|---|
| reviewboard/templates/reviews/review_request_box.html |
|---|
| reviewboard/templates/reviews/review_request_dlgs.html |
|---|
| reviewboard/templates/reviews/parts/file_attachment_thumbnail.html |
|---|
| reviewboard/webapi/resources/base_file_attachment.py |
|---|