Summary

Commit ID is not included in review request if --include is used on rbt post.

Review Request #5818 — Created May 13, 2014 and submitted May 23, 2014, 3:14 p.m.

Information

Owner

matthewcmaclean

Repository

RBTools

Branch

master

Bugs

3328

Depends On

Commit

7557d04...

Reviewers

Groups

rbtools, students

People

Description

Previously when --include was used on an rbt post, it would take the
commit ID of the current commit. The issue is that if someone
uploaded multiple files from the same commit separately, the
identical commit IDs would cause conflicts in the ReviewRequests. The
solution is to not include the commit ID when "--include" is used on
an rbt post.

Testing Done

Made a commit with two files in the change. I was able to post and
publish both without error, which would not happen normally. When
looking on the review board web ui, there was no commit id
associated with either.

Issues

Description	From	Last Updated
I'd love to see a comment explaining why we do this.	david	May 23, 2014, 2:08 p.m.

rbtools/commands/post.py (Diff revision 1)
The issue has been resolved. Show all issues
```
I'd love to see a comment explaining why we do this.
```

Change Summary:

Added comments to change.

Commit:

-	59a875d28e267309ee70e974c83650cc9a32103c
+	7557d0472a637d200974e471c2e359457d229603

Diff:

Revision 2 (+6)

Show changes

rbtools/commands/post.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbtools/commands/post.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    rbtools/commands/post.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.6.x (a65ee8d)

rbtools/commands/post.py (Diff revision 1)