Commit ID is not included in review request if --include is used on rbt post.

Review Request #5818 — Created May 13, 2014 and submitted

Information

RBTools
master
7557d04...

Reviewers

Previously when --include was used on an rbt post, it would take the
commit ID of the current commit. The issue is that if someone
uploaded multiple files from the same commit separately, the
identical commit IDs would cause conflicts in the ReviewRequests. The
solution is to not include the commit ID when "--include" is used on
an rbt post.

Made a commit with two files in the change. I was able to post and
publish both without error, which would not happen normally. When
looking on the review board web ui, there was no commit id
associated with either.

Description From Last Updated

I'd love to see a comment explaining why we do this.

daviddavid
david
  1. 
      
  2. rbtools/commands/post.py (Diff revision 1)
     
     
    Show all issues

    I'd love to see a comment explaining why we do this.

  3. 
      
MA
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        rbtools/commands/post.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        rbtools/commands/post.py
      Ignored Files:
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
MA
Review request changed
Status:
Completed
Change Summary:
Pushed to release-0.6.x (a65ee8d)