-
-
-
reviewboard/webapi/resources/session.py (Diff revision 1) You can put the """ on the same line when the docstring is just one line.
-
-
reviewboard/webapi/resources/session.py (Diff revision 1) Single-line if statements in python don't need parens. It's also somewhat more idiomatic to write
if not request.user.is_authenticated(): -
-
-
-
reviewboard/webapi/tests/test_session.py (Diff revision 1) Imports should be in alphabetical order (within their pep-8 defined section)
-
reviewboard/webapi/tests/test_session.py (Diff revision 1) There's a few problems with this line. First of all, I don't know what this comment means. Second, there should be a space after the #. Third, comments should be full sentences with capitalization, and last, there's some trailing whitespace.
Added support for DELETE request to api/session and created test cases for it.
Review Request #5817 — Created May 13, 2014 and submitted
| Information | |
|---|---|
| PeterTran | |
| Review Board | |
| master | |
| 3294 | |
| 4590585... | |
| Reviewers | |
| students | |
Added support for DELETE request to api/session and created test cases for it.
Tested the base case where user delete's their own Session.
Tested when another user tries to delete another person's session.
| Description | From | Last Updated |
|---|---|---|
|
There should be only one blank line here. |
 david
|
|
|
You can put the """ on the same line when the docstring is just one line. |
david
|
|
|
Remove this line. |
david
|
|
|
Single-line if statements in python don't need parens. It's also somewhat more idiomatic to write if not request.user.is_authenticated(): |
david
|
|
|
Can you put a comma after this? |
david
|
|
|
Can you put a comma after this? |
david
|
|
|
Trailing whitespace. |
david
|
|
|
Imports should be in alphabetical order (within their pep-8 defined section) |
david
|
|
|
There's a few problems with this line. First of all, I don't know what this comment means. Second, there should … |
david
|
|
|
'User' imported but unused |
 reviewbot
|
|
|
'Session' imported but unused |
reviewbot
|
|
|
'get_session_url' imported but unused |
reviewbot
|
|
|
Col: 27 E203 whitespace before ':' |
reviewbot
|
|
|
Col: 1 W293 blank line contains whitespace |
reviewbot
|
|
|
'SessionStore' imported but unused |
reviewbot
|
|
|
'Session' imported but unused |
reviewbot
|
|
|
Col: 13 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 34 W291 trailing whitespace |
reviewbot
|
|
|
Col: 1 W391 blank line at end of file |
reviewbot
|
PE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+55) |
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/session.py reviewboard/webapi/tests/test_session.py Ignored Files: -
-
reviewboard/webapi/resources/session.py (Diff revision 2) Col: 1 W293 blank line contains whitespace
-
reviewboard/webapi/tests/test_session.py (Diff revision 2) Col: 13 E128 continuation line under-indented for visual indent
-
-
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/webapi/resources/session.py reviewboard/webapi/tests/test_session.py Ignored Files: -
-
-
-
-