Fix modalBox click handler to respect disabled state

Review Request #5816 — Created May 13, 2014 and submitted

salam0smy
Djblets
master
3338
5803
2ba9e20...
djblets, students

The button's click event used to fire in a modalbox and destroy it, even when the button is disabled.
I added a check that the button is enabled before firing the default click event in a modalbox.

1- click the button when it is disabled, the modalbox stays and doesn't get distroyed
2- select a file, click upload button, click event fires normally

david
  1. Your code looks OK, but I'd like you to work on your review request description.

    The summary tells what you did, but it can still be improved to give people an indication of what part of the djblets codebase it addresses. Perhaps something like "Fix modalBox click handler to respect disabled state"?

    In the description and testing done, make sure that everything uses full sentences with capitalization and punctuation.

  2. 
      
SA
david
  1. This looks good. I'm going to hold off on pushing it because we're frozen for release.

  2. 
      
SA
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.8.x (da531b9)
Loading...