Summary

Fix modalBox click handler to respect disabled state

Review Request #5816 — Created May 13, 2014 and submitted May 20, 2014, 1:34 p.m.

Information

Owner

salam0smy

Repository

Djblets

Branch

master

Bugs

3338

Depends On

Blocks

5803

Commit

2ba9e20...

Reviewers

Groups

djblets, students

People

Description

The button's click event used to fire in a modalbox and destroy it, even when the button is disabled.
I added a check that the button is enabled before firing the default click event in a modalbox.

Testing Done

1- click the button when it is disabled, the modalbox stays and doesn't get distroyed
2- select a file, click upload button, click event fires normally

Your code looks OK, but I'd like you to work on your review request description.

The summary tells what you did, but it can still be improved to give people an indication of what part of the djblets codebase it addresses. Perhaps something like "Fix modalBox click handler to respect disabled state"?

In the description and testing done, make sure that everything uses full sentences with capitalization and punctuation.

Summary:: check button is not disabled before firing click event
Fix modalBox click handler to respect disabled state
Description:: ~
the button's click event used to fire in a modalbox and destroy it, even when the button is disabled.
~ I added a check that the button is enabled before firing the default click event in a modalbox
~
The button's click event used to fire in a modalbox and destroy it, even when the button is disabled.
~ I added a check that the button is enabled before firing the default click event in a modalbox.

Ship it!

This looks good. I'm going to hold off on pushing it because we're frozen for release.

Status:: Completed
Change Summary:: Pushed to release-0.8.x (da531b9)

~		the button's click event used to fire in a modalbox and destroy it, even when the button is disabled.
~		I added a check that the button is enabled before firing the default click event in a modalbox
	~	The button's click event used to fire in a modalbox and destroy it, even when the button is disabled.
	~	I added a check that the button is enabled before firing the default click event in a modalbox.