Remove the Pygments runtime dependency checks.

Review Request #5811 — Created May 12, 2014 and submitted

Information

Review Board
release-2.0.x
7504939...

Reviewers

We have some really old code (Makefile days) for checking if syntax
highlighting can be enabled, based on having Pygments, and having a
minimum version of it. This code, in combination with some other code,
ends up creating some ugly and unnecessary circular dependencies between
parts of the product that only appear if you start importing certain
modules first.

These days, we have actual dependencies that get installed with the
product. This check is no longer useful, and causes more harm than good.
This change removes the check and all calls.

Unit tests pass.

Syntax highlighting still works.

Tested the circular dependency issue I hit in an extension, and the
problem went away.

david
  1. Ship It!

    1. I'd forgotten about the Makefile!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (023e80b)
Loading...