Fix populating extension settings forms from defaults.
Review Request #5805 — Created May 12, 2014 and submitted — Latest diff uploaded
The move to
SiteSettingsForm
broke extension configuration pages
slightly. They accessed the settings object usingsettings.get(key)
, and
not throughsettings[key]
, which prevented any defaults from being
fetched.There's now a
get()
function that works just like attribute access,
returning defaults, but with the semantics of the standarddict.get()
call. This complementsset()
.
Unit test passed.
Loaded an extension config form with a blank settings dictionary and
saw the defaults used, instead of blank fields.