-
-
djblets/extensions/settings.py (Diff revision 1) Can you add comments for why these methods are required?
Fix populating extension settings forms from defaults.
Review Request #5805 — Created May 12, 2014 and submitted
The move to
SiteSettingsForm
broke extension configuration pages
slightly. They accessed the settings object usingsettings.get(key)
, and
not throughsettings[key]
, which prevented any defaults from being
fetched.There's now a
get()
function that works just like attribute access,
returning defaults, but with the semantics of the standarddict.get()
call. This complementsset()
.
Unit test passed.
Loaded an extension config form with a blank settings dictionary and
saw the defaults used, instead of blank fields.
Description | From | Last Updated |
---|---|---|
Can you add comments for why these methods are required? |
david |
Change Summary:
Added some docstrings and comments.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+22) |