The review-requests API call now returns private review-requests for all users when made by an administrator.

Review Request #5798 — Created May 12, 2014 and submitted

rvaiya
Review Board
master
2766
9967572...
reviewboard

The review-requests API call now returns private review-requests for all users when made by an administrator.

A deployment consisting of a regular and administrative user was created
and the review-requests query was made by the administrative user. The
results yielded all private review-requests of all users.

Description From Last Updated

You used tabs to indent these. Python files should use four-space indentation and never have a tab character. You also ...

daviddavid
RV
david
  1. 
      
  2. reviewboard/reviews/managers.py (Diff revision 1)
     
     
     

    You used tabs to indent these. Python files should use four-space indentation and never have a tab character.

    You also don't need the parens in if statements. The first line should read if user.is_superuser:

  3. 
      
RV
RV
david
  1. This looks good. I'm going to hold off on pushing this because the 2.0.x branch is locked down for release.

  2. 
      
RV
Review request changed

Status: Closed (submitted)

Loading...