Make a small improvement to unicode diffs in 1.7.x

Review Request #5784 — Created May 8, 2014 and submitted

Information

Review Board
release-1.7.x
bc4316d...

Reviewers

Generally, Review Board 2.0's support for unicode is much, much better than
1.7.x, but this is a small enough change that it's probably worth making. Some
of the filename processing can do operations which will fail if the filenames
an un-decoded utf8, so convert all filenames from diffs to unicode if the
SCMTool didn't already.

Ran unit tests.

chipx86
  1. Is this going to be merged to 2.0, or is it 1.7 only?

    1. 1.7 only. 2.0 has a much more comprehensive treatment of string encodings throughout.

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (b41888d)
Loading...