Issue 3300 Confirm added, when discarding a review draft

Review Request #5779 — Created May 7, 2014 and discarded

Audore
Review Board
master
reviewboard, students
david

Fixes the issue 3300: When a user has a draft review, and opens up the "Edit Review" box to finalize their comments and publish, the "Discard Review" command doesn't confirm at all. This makes it easy to lose work, especially when using the keyboard to move over to the command buttons. (https://code.google.com/p/reviewboard/issues/detail?id=3300)

I added the onDiscardClicked function to the file, its about the same as in draftReviewBannerView.js. Should I somehow refactor the code, that it's usable for both occasions?

Testing is done on my development server and the fix works well. I didn't notice any abnormal behavior.

Description From Last Updated

This section here is about the same code as in draftReviewBannerView.js. Is there a way to refactor the code so, ...

AU Audore
AU
  1. 
      
  2. reviewboard/static/rb/js/views/reviewDialogView.js (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    This section here is about the same code as in draftReviewBannerView.js. Is there a way to refactor the code so, that about the same function (_onDiscardClicked ) wouldn't be used twice?

  3. 
      
AU
Review request changed

Status: Discarded

Loading...