-
-
djblets/webapi/resources.py (Diff revision 1) I wasn't terribly comfortable with this message handling, but I wasn't sure of a better way. The only alternative I could think of was some sort of new errors like PublishError/PUBLISH_ERROR that could easily take a custom message. Maybe a QueryError/QUERY_ERROR? Would that be better?
MC
-
-
djblets/webapi/resources.py (Diff revision 1) Since this is a single line, it doesn't need the parens.
-
djblets/webapi/resources.py (Diff revision 1) Mind putting this in an
else:
clause? It would make it more symmetric.
MC
Change Summary:
Formatting fixes.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+6 -1) |
MC
Change Summary:
Here's another attempt. There are no generic error classes in djblets, so I added one to util. My extension's AuthBackend now raises a query error with a helpful string if it has problems talking to the external service.
Summary: |
|
||||
---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 3 (+16) |