Make post-review less sensitive to CVS server name aliases
Review Request #576 — Created Oct. 1, 2008 and submitted
|Review Board SVN (deprecated)|
You might have many aliases for your CVS server. People can set up their sandboxes using any of these names. Unfortunately, if the hostname used in the reviewboard repository definition doesn't match what the user used in their cvs checkout command, post-review will barf. This patch converts the local hostname to the canonical name for the machine. When setting up the CVS repository object all you have to do is use the canonical name for the server.
Confirmed that it worked for our setup at work. Note however that we have a kind of odd behind-a-firewall network setup. The canonical name doesn't include any domain information. This patch might need adjustment to be more robust in a more normal network setup.
Committed with minor changes as r1522. Thanks!