Google Code post-receive hook

Review Request #5744 — Created April 26, 2014 and submitted

b.ramnani
Review Board
master
d232545...
reviewboard
chipx86, david, mike_conley, smacleod

This is a Google Code post-receive hook that will automatically close review requests as "submitted" after a push. To determine which review requests should be closed, it scans through each commit's commit message for the following strings (case-insensitive): "Reviewed at <reviewboard_url>/r/<id>" or "Review request #<id>".

This is what the JSON payload looks like:
http://code.google.com/p/support/wiki/PostCommitWebHooks

All tests performed using an SVN and Mercurial repositories.

1) Push with the review request id in the commit message. Review request closed. [PASSED]
2) Push without a review request id in the commit message. (Error: Review request does not exist) [PASSED].
3) Push with non existent review request id. (Error: Review request does not exist) [PASSED]
4) Push with review id in the message that is already submitted. (logged a warning: request id already submitted.) [PASSED]
5) Push with review id in the message that has been marked as discarded. (review request marked as submitted.) [PASSED]

Description From Last Updated

Can you call it "Google Code" instead of "googlecode"?

daviddavid

There's an extra period before the : in this message. Please also add exc_info=1 to the logging call.

daviddavid

Please add exc_info=1 to the logging call.

daviddavid

Can you make this text a comment rather than part of the docstring? It's less about describing the behavior of ...

daviddavid

Can you capitalize "SVN" and "Mercurial" in here?

daviddavid
B.
david
  1. 
      
  2. reviewboard/hostingsvcs/googlecode.py (Diff revision 2)
     
     
     
     

    Can you call it "Google Code" instead of "googlecode"?

  3. 
      
B.
B.
david
  1. 
      
  2. reviewboard/hostingsvcs/googlecode.py (Diff revision 3)
     
     

    There's an extra period before the : in this message.

    Please also add exc_info=1 to the logging call.

  3. reviewboard/hostingsvcs/googlecode.py (Diff revision 3)
     
     

    Please add exc_info=1 to the logging call.

  4. reviewboard/hostingsvcs/googlecode.py (Diff revision 3)
     
     
     
     
     
     

    Can you make this text a comment rather than part of the docstring? It's less about describing the behavior of the method and more about the implementation of it.

  5. reviewboard/hostingsvcs/googlecode.py (Diff revision 3)
     
     
     
     

    Can you capitalize "SVN" and "Mercurial" in here?

  6. 
      
B.
B.
david
  1. Ship It!

  2. 
      
B.
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (ccc1565)
Loading...