Summary

Google Code post-receive hook

Review Request #5744 — Created April 26, 2014 and submitted May 1, 2014, 2:07 p.m.

Information

Owner

b.ramnani

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

d232545...

Reviewers

Groups

reviewboard

People

chipx86, david, mike_conley, smacleod

Description

This is a Google Code post-receive hook that will automatically close review requests as "submitted" after a push. To determine which review requests should be closed, it scans through each commit's commit message for the following strings (case-insensitive): "Reviewed at <reviewboard_url>/r/<id>" or "Review request #<id>".

This is what the JSON payload looks like:
http://code.google.com/p/support/wiki/PostCommitWebHooks

Testing Done

All tests performed using an SVN and Mercurial repositories.
1) Push with the review request id in the commit message. Review request closed. [PASSED]

2) Push without a review request id in the commit message. (Error: Review request does not exist) [PASSED].

3) Push with non existent review request id. (Error: Review request does not exist) [PASSED]

4) Push with review id in the message that is already submitted. (logged a warning: request id already submitted.) [PASSED]

5) Push with review id in the message that has been marked as discarded. (review request marked as submitted.) [PASSED]

Issues

Description	From	Last Updated
Can you call it "Google Code" instead of "googlecode"?	david	April 27, 2014, 3:21 p.m.
There's an extra period before the : in this message. Please also add exc_info=1 to the logging call.	david	May 1, 2014, 2:28 a.m.
Please add exc_info=1 to the logging call.	david	May 1, 2014, 2:28 a.m.
Can you make this text a comment rather than part of the docstring? It's less about describing the behavior of …	david	May 1, 2014, 2:29 a.m.
Can you capitalize "SVN" and "Mercurial" in here?	david	May 1, 2014, 2:02 p.m.

Summary:

-	[WIP] googlecode post-receive hook
+	googlecode post-receive hook

Testing Done:

	+	All tests performed using an SVN repository.
	+
	+	1) Push with the review request id in the commit message. Review request closed. [PASSED]
	+	2) Push without a review request id in the commit message. (Error: Review request does not exist) [PASSED].
	+	3) Push with non existent review request id. (Error: Review request does not exist) [PASSED]
	+	4) Push with review id in the message that is already submitted. (logged a warning: request id already submitted.) [PASSED]
	+	5) Push with review id in the message that has been marked as discarded. (review request marked as submitted.) [PASSED]

Commit:

-	6379802a7ea59fc820b9cfe613f888135341500a
+	ba3eafa4cbb339ab210a2b0cf643e0dea1fb811f

Diff:

Revision 2 (+67 -1)

Show changes

	reviewboard/hostingsvcs/bitbucket.py
	reviewboard/hostingsvcs/googlecode.py

reviewboard/hostingsvcs/googlecode.py (Diff revision 2)

Show all issues

Can you call it "Google Code" instead of "googlecode"?

Commit:

-	ba3eafa4cbb339ab210a2b0cf643e0dea1fb811f
+	02ea8fd4c26a3a47b4cacec518d20f5abc275989

Diff:

Revision 3 (+67 -1)

Show changes

	reviewboard/hostingsvcs/bitbucket.py
	reviewboard/hostingsvcs/googlecode.py

Summary:

-	googlecode post-receive hook
+	Google Code post-receive hook

Description:

~		This is a Googlecode post-receive hook that will automatically close review requests as "submitted" after a push. To determine which review requests should be closed, it scans through each commit's commit message for the following strings (case-insensitive): "Reviewed at <reviewboard_url>/r/<id>" or "Review request #<id>".
	~	This is a Google Code post-receive hook that will automatically close review requests as "submitted" after a push. To determine which review requests should be closed, it scans through each commit's commit message for the following strings (case-insensitive): "Reviewed at <reviewboard_url>/r/<id>" or "Review request #<id>".

		This is what the JSON payload looks like:
		http://code.google.com/p/support/wiki/PostCommitWebHooks

Testing Done:

~		All tests performed using an SVN repository.
	~	All tests performed using an SVN and Mercurial repositories.

		1) Push with the review request id in the commit message. Review request closed. [PASSED]
		2) Push without a review request id in the commit message. (Error: Review request does not exist) [PASSED].
		3) Push with non existent review request id. (Error: Review request does not exist) [PASSED]
		4) Push with review id in the message that is already submitted. (logged a warning: request id already submitted.) [PASSED]
		5) Push with review id in the message that has been marked as discarded. (review request marked as submitted.) [PASSED]

reviewboard/hostingsvcs/googlecode.py (Diff revision 3)

Show all issues

There's an extra period before the : in this message.

Please also add exc_info=1 to the logging call.

reviewboard/hostingsvcs/googlecode.py (Diff revision 3)
Show all issues
```
Please add exc_info=1 to the logging call.
```

reviewboard/hostingsvcs/googlecode.py (Diff revision 3)

Show all issues

Can you make this text a comment rather than part of the docstring? It's less about describing the behavior of the method and more about the implementation of it.

reviewboard/hostingsvcs/googlecode.py (Diff revision 3)
Show all issues
```
Can you capitalize "SVN" and "Mercurial" in here?
```

Commit:

-	02ea8fd4c26a3a47b4cacec518d20f5abc275989
+	b7183c0bef332a006d3c76ec95f717983bd0b7f8

Diff:

Revision 4 (+67 -1)

Show changes

	reviewboard/hostingsvcs/bitbucket.py
	reviewboard/hostingsvcs/googlecode.py

Commit:

-	b7183c0bef332a006d3c76ec95f717983bd0b7f8
+	d2325451d62426cc9a4de8fcde738e437951252d

Diff:

Revision 5 (+67 -1)

Show changes

	reviewboard/hostingsvcs/bitbucket.py
	reviewboard/hostingsvcs/googlecode.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (ccc1565)