- Summary:
-
[WIP] googlecode post-receive hookgooglecode post-receive hook
- Testing Done:
-
+ All tests performed using an SVN repository.
+ + 1) Push with the review request id in the commit message. Review request closed. [PASSED]
+ 2) Push without a review request id in the commit message. (Error: Review request does not exist) [PASSED]. + 3) Push with non existent review request id. (Error: Review request does not exist) [PASSED] + 4) Push with review id in the message that is already submitted. (logged a warning: request id already submitted.) [PASSED] + 5) Push with review id in the message that has been marked as discarded. (review request marked as submitted.) [PASSED] - Commit:
-
6379802a7ea59fc820b9cfe613f888135341500aba3eafa4cbb339ab210a2b0cf643e0dea1fb811f
Google Code post-receive hook
Review Request #5744 — Created April 26, 2014 and submitted
This is a Google Code post-receive hook that will automatically close review requests as "submitted" after a push. To determine which review requests should be closed, it scans through each commit's commit message for the following strings (case-insensitive): "Reviewed at <reviewboard_url>/r/<id>" or "Review request #<id>".
This is what the JSON payload looks like:
http://code.google.com/p/support/wiki/PostCommitWebHooks
All tests performed using an SVN and Mercurial repositories.
1) Push with the review request id in the commit message. Review request closed. [PASSED]
2) Push without a review request id in the commit message. (Error: Review request does not exist) [PASSED].
3) Push with non existent review request id. (Error: Review request does not exist) [PASSED]
4) Push with review id in the message that is already submitted. (logged a warning: request id already submitted.) [PASSED]
5) Push with review id in the message that has been marked as discarded. (review request marked as submitted.) [PASSED]
| Description | From | Last Updated |
|---|---|---|
|
Can you call it "Google Code" instead of "googlecode"? |
 david
|
|
|
There's an extra period before the : in this message. Please also add exc_info=1 to the logging call. |
david
|
|
|
Please add exc_info=1 to the logging call. |
david
|
|
|
Can you make this text a comment rather than part of the docstring? It's less about describing the behavior of … |
david
|
|
|
Can you capitalize "SVN" and "Mercurial" in here? |
david
|
B.
B.
- Summary:
-
googlecode post-receive hookGoogle Code post-receive hook
- Description:
-
~ This is a Googlecode post-receive hook that will automatically close review requests as "submitted" after a push. To determine which review requests should be closed, it scans through each commit's commit message for the following strings (case-insensitive): "Reviewed at <reviewboard_url>/r/<id>" or "Review request #<id>".
~ This is a Google Code post-receive hook that will automatically close review requests as "submitted" after a push. To determine which review requests should be closed, it scans through each commit's commit message for the following strings (case-insensitive): "Reviewed at <reviewboard_url>/r/<id>" or "Review request #<id>".
This is what the JSON payload looks like:
http://code.google.com/p/support/wiki/PostCommitWebHooks - Testing Done:
-
~ All tests performed using an SVN repository.
~ All tests performed using an SVN and Mercurial repositories.
1) Push with the review request id in the commit message. Review request closed. [PASSED]
2) Push without a review request id in the commit message. (Error: Review request does not exist) [PASSED]. 3) Push with non existent review request id. (Error: Review request does not exist) [PASSED] 4) Push with review id in the message that is already submitted. (logged a warning: request id already submitted.) [PASSED] 5) Push with review id in the message that has been marked as discarded. (review request marked as submitted.) [PASSED]