Added sandboxing to ReviewRequestFieldset
Review Request #5738 — Created April 24, 2014 and submitted
Information | |
---|---|
edwinzg | |
Review Board | |
master | |
Reviewers | |
reviewboard, students | |
Added sandboxing to ReviewRequestFieldset
Wrote unit tests for tests
Unit testing for init function for BaseReviewRequestFieldSet and BaseReviewRequestField, is_empty for BaseReviewRequestFieldSet, and should_render for BaseReviewRequestField
Description | From | Last Updated |
---|---|---|
Because the fields are third-party, this should be wrapped too. |
|
|
Should wrap this. |
|
|
Can you put the dictionary items on their own lines? |
|
|
This should indicate the class name: logging.error('Error instantiating ReviewRequestfieldSet %r: %s', field_cls, e, exc_info=1) |
|
|
This should include the class name as above. |
|
|
This should include the class name as above. |
|
|
Almost. What I want looks more like this: context = Context({ 'review_request_details': review, 'request': request, }) |
|
|
The text here still isn't great-- "fieldset_cls" is just an implementation detail of this method. It should read something like … |
|
Summary: |
|
||||||
---|---|---|---|---|---|---|---|
Description: |
|
||||||
Diff: |
Revision 2 (+9 -1) |
-
-
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 2) Because the fields are third-party, this should be wrapped too.
-
Summary: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||
Testing Done: |
|
|||||||||
Diff: |
Revision 6 (+170 -25) |
-
-
reviewboard/extensions/tests.py (Diff revision 6) Can you put the dictionary items on their own lines?
-
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 6) This should indicate the class name:
logging.error('Error instantiating ReviewRequestfieldSet %r: %s', field_cls, e, exc_info=1)
-
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 6) This should include the class name as above.
-
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 6) This should include the class name as above.
-
-
reviewboard/extensions/tests.py (Diff revision 7) Almost. What I want looks more like this:
context = Context({ 'review_request_details': review, 'request': request, })
-
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 7) The text here still isn't great-- "fieldset_cls" is just an implementation detail of this method. It should read something like "Error instantiating ReviewRequestFieldset %r: %s"