Added sandboxing to ReviewRequestFieldset
Review Request #5738 — Created April 24, 2014 and submitted
Added sandboxing to ReviewRequestFieldset
Wrote unit tests for tests
Unit testing for init function for BaseReviewRequestFieldSet and BaseReviewRequestField, is_empty for BaseReviewRequestFieldSet, and should_render for BaseReviewRequestField
Description | From | Last Updated |
---|---|---|
Because the fields are third-party, this should be wrapped too. |
david | |
Should wrap this. |
david | |
Can you put the dictionary items on their own lines? |
david | |
This should indicate the class name: logging.error('Error instantiating ReviewRequestfieldSet %r: %s', field_cls, e, exc_info=1) |
david | |
This should include the class name as above. |
david | |
This should include the class name as above. |
david | |
Almost. What I want looks more like this: context = Context({ 'review_request_details': review, 'request': request, }) |
david | |
The text here still isn't great-- "fieldset_cls" is just an implementation detail of this method. It should read something like … |
david |
- Summary:
-
Added sandboxing to register_review_request_fieldset[WIP] Added sandboxing to ReviewRequestFieldset
- Description:
-
~ Added sandboxing to register_review_request_fieldset
~ Added sandboxing to ReviewRequestFieldset
- Summary:
-
[WIP] Added sandboxing to ReviewRequestFieldsetAdded sandboxing to ReviewRequestFieldset
- Description:
-
Added sandboxing to ReviewRequestFieldset
+ + Wrote unit tests for tests
- Testing Done:
-
+ Unit testing for init function for BaseReviewRequestFieldSet and BaseReviewRequestField, is_empty for BaseReviewRequestFieldSet, and should_render for BaseReviewRequestField